Project

General

Profile

Feature #16064

Have some sanity checks on puppet code

Added by groente about 1 year ago. Updated about 2 months ago.

Status:
Needs Validation
Priority:
Normal
Assignee:
Sysadmins
Category:
-
Target version:
-
Start date:
10/17/2018
Due date:
% Done:

40%

Feature Branch:
feature/16064-sanity-checks-for-puppet
Type of work:
Sysadmin
Blueprint:
Starter:
Affected tool:

Description

A pre-receive hook can do some basic checks on any puppet code being pushed

History

#1 Updated by groente about 1 year ago

  • Assignee changed from groente to intrigeri
  • % Done changed from 0 to 40
  • QA Check set to Ready for QA
  • Feature Branch set to feature/16064-sanity-checks-for-puppet

Since we briefly discussed sanity checks, here's something that should ensure you won't have to wade through my typo's again ;-) Let me know what you think!

#2 Updated by groente about 1 year ago

  • Assignee changed from intrigeri to bertagaz

Hey bertagaz, actually, I'd quite like to know your thoughts on this aswell!

#3 Updated by intrigeri 11 months ago

FWIW, I don't mind taking this over if it helps move it forward.

#4 Updated by intrigeri 6 months ago

  • Status changed from Confirmed to Needs Validation

#5 Updated by intrigeri 3 months ago

  • Assignee changed from bertagaz to Sysadmins

#6 Updated by intrigeri 2 months ago

The work anarcat is doing at Tor on this front could be relevant here: https://trac.torproject.org/projects/tor/ticket/31226

#7 Updated by intrigeri about 2 months ago

intrigeri wrote:

The work anarcat is doing at Tor on this front could be relevant here: https://trac.torproject.org/projects/tor/ticket/31226

While it would be nice, on the long term, to use the same validator as anarcat (it does much more than ours and we don't have to maintain it), for now I opted for improving the initial code proposed by groente, as a shortest path towards having some checks.

I've improved the code quite a bit (bug fixes, 1 new feature, performance improvements, robustness, code style) and it Works On My Machine™. Please review and deploy if happy :)

Also available in: Atom PDF