Project

General

Profile

Bug #16021

Don't override Debian's system-wide Thunderbird configuration

Added by anonym 12 months ago. Updated 4 months ago.

Status:
Confirmed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
10/02/2018
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Email Client

Description

Due to config/chroot_local-includes/etc/thunderbird/pref/thunderbird.js we overwrite any pref changes made for the Debian package. I noticed this when working on #15942 and #15959 -- the needed setting for intl.locale.requested was overwritten by us. While I've fixed that one there's at least one more interesting setting:

// This setting is a workaround for some crashes inside the JS engine.
// By this Thunderbird will use more memory and acting slower as the sharing
// memory between interacting JS files is disabled.
pref ("javascript.options.baselinejit", false);

We should sync our config, and possibly consider using a patch instead so upstream changes are not silently lost like this.


Related issues

Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by anonym 12 months ago

#2 Updated by intrigeri 12 months ago

  • Subject changed from Sync with Debian's system-wide Thunderbird configuration to Don't override Debian's system-wide Thunderbird configuration
  • Assignee set to CyrilBrulebois
  • Target version set to Tails_3.12

I think a patch is the way to go, or even better, iff. the second definition overrides the first one when a pref is set twice in the same file, I would maintain a config/chroot_local-includes/usr/share/tails/thunderbird.js file and append it to the one installed by the Debian package at ISO build time.

IMO this can wait until December and 3.12 so no hurry, please focus on your 3.10 and Oct-Dec FT tasks first.

#3 Updated by CyrilBrulebois 9 months ago

#4 Updated by CyrilBrulebois 9 months ago

#5 Updated by CyrilBrulebois 9 months ago

  • Related to deleted (Feature #15507: Core work 2019Q1: Foundations Team)

#6 Updated by CyrilBrulebois 9 months ago

#7 Updated by intrigeri 9 months ago

  • Target version changed from Tails_3.12 to Tails_3.13

#8 Updated by hefee 7 months ago

Can't we have a /etc/thunderbird/pref/zz_tails.js or aa_tails.js, for not neet need to have patches for the thunderbird.js?

The comment inside /etc/thunderbird/pref/thunderbird.js are pointing that this should be possible:

// This is the Debian specific preferences file for Mozilla Thunderbird
// You can make any change in here, it is the purpose of this file.
// You can, with this file and all files present in the directory
//
//      /etc/thunderbird/pref directory
//
// override any preference that is present in the directory
//
//      /usr/lib/thunderbird/defaults/pref
//
// While your changes will be kept on upgrade if you modify files in
// /etc/thunderbird/pref, please note that they won't be kept if you
// do them in /usr/lib/thunderbird/defaults/pref.

For extensions you need to place those configuration in f.ex:
/etc/xul-ext/torbirdy.js
otherwise you can't overwrite configs from /usr/share/xul-ext/torbirdy/defaults/preferences/prefs.js

This at least looks for me the cleanest way to do, as we don't need to apply patches and Debian/Tails part is clearly separated etc.

#9 Updated by CyrilBrulebois 6 months ago

AFAICT and IIRC: Having file snippets used to work, but support for that was broken/removed a few releases ago.

See fdcfa34e7d62df85329179b26ffcfdbad95098d7 and d6e440b0f44126f3c9371df155e72c4e5a2bddc3 for Torbirdy.

#10 Updated by CyrilBrulebois 6 months ago

  • Assignee changed from CyrilBrulebois to intrigeri

Hey @intrigeri, this bug was punted already and I don't want to rush anything here; I'd rather concentrate on testing 60.5.1 instead. Any objections to postponing this ticket to 3.14? Sorry for the late notice; wasn't expecting to be so busy with Thunderbird itself. :/

#11 Updated by CyrilBrulebois 6 months ago

FTAOD, current layout looks like this:

$ dpkg --contents thunderbird_60.5.1-1~deb9u1.0tails1_amd64.deb | grep pref
drwxr-xr-x root/root         0 2019-03-17 15:05 ./etc/thunderbird/pref/
-rw-r--r-- root/root      1759 2018-10-11 03:29 ./etc/thunderbird/pref/thunderbird.js
drwxr-xr-x root/root         0 2019-03-17 15:05 ./usr/share/thunderbird/defaults/pref/
-rw-r--r-- root/root       245 2019-03-17 15:05 ./usr/share/thunderbird/defaults/pref/channel-prefs.js
-rw-r--r-- root/root        73 2018-08-16 17:03 ./usr/share/thunderbird/defaults/pref/vendor.js
lrwxrwxrwx root/root         0 2019-03-17 15:05 ./usr/share/thunderbird/defaults/syspref -> /etc/thunderbird/pref

#12 Updated by intrigeri 6 months ago

  • Target version changed from Tails_3.13 to Tails_3.14

I'd rather concentrate on testing 60.5.1 instead. Any objections to postponing this ticket to 3.14?

ACK: first things first.

#13 Updated by intrigeri 6 months ago

#14 Updated by intrigeri 6 months ago

#15 Updated by intrigeri 6 months ago

  • Assignee changed from intrigeri to CyrilBrulebois

#16 Updated by CyrilBrulebois 4 months ago

  • Target version changed from Tails_3.14 to Tails_3.15

#17 Updated by intrigeri 4 months ago

  • Assignee deleted (CyrilBrulebois)
  • Target version deleted (Tails_3.15)

(As per our newly documented workflow, dropping target version and making this ticket up for grabs.)

Also available in: Atom PDF