Don't override Debian's system-wide Thunderbird configuration
config/chroot_local-includes/etc/thunderbird/pref/thunderbird.js we overwrite any pref changes made for the Debian package. I noticed this when working on #15942 and #15959 -- the needed setting for
intl.locale.requested was overwritten by us. While I've fixed that one there's at least one more interesting setting:
We should sync our config, and possibly consider using a patch instead so upstream changes are not silently lost like this.
- Subject changed from Sync with Debian's system-wide Thunderbird configuration to Don't override Debian's system-wide Thunderbird configuration
- Assignee set to CyrilBrulebois
- Target version set to Tails_3.12
I think a patch is the way to go, or even better, iff. the second definition overrides the first one when a pref is set twice in the same file, I would maintain a
config/chroot_local-includes/usr/share/tails/thunderbird.js file and append it to the one installed by the Debian package at ISO build time.
IMO this can wait until December and 3.12 so no hurry, please focus on your 3.10 and Oct-Dec FT tasks first.
Can't we have a /etc/thunderbird/pref/zz_tails.js or aa_tails.js, for not neet need to have patches for the thunderbird.js?
The comment inside /etc/thunderbird/pref/thunderbird.js are pointing that this should be possible:
// This is the Debian specific preferences file for Mozilla Thunderbird // You can make any change in here, it is the purpose of this file. // You can, with this file and all files present in the directory // // /etc/thunderbird/pref directory // // override any preference that is present in the directory // // /usr/lib/thunderbird/defaults/pref // // While your changes will be kept on upgrade if you modify files in // /etc/thunderbird/pref, please note that they won't be kept if you // do them in /usr/lib/thunderbird/defaults/pref.
For extensions you need to place those configuration in f.ex:
otherwise you can't overwrite configs from
This at least looks for me the cleanest way to do, as we don't need to apply patches and Debian/Tails part is clearly separated etc.
#10 Updated by CyrilBrulebois 4 months ago
- Assignee changed from CyrilBrulebois to intrigeri
Hey @intrigeri, this bug was punted already and I don't want to rush anything here; I'd rather concentrate on testing 60.5.1 instead. Any objections to postponing this ticket to 3.14? Sorry for the late notice; wasn't expecting to be so busy with Thunderbird itself. :/
#11 Updated by CyrilBrulebois 4 months ago
FTAOD, current layout looks like this:
$ dpkg --contents thunderbird_60.5.1-1~deb9u1.0tails1_amd64.deb | grep pref drwxr-xr-x root/root 0 2019-03-17 15:05 ./etc/thunderbird/pref/ -rw-r--r-- root/root 1759 2018-10-11 03:29 ./etc/thunderbird/pref/thunderbird.js drwxr-xr-x root/root 0 2019-03-17 15:05 ./usr/share/thunderbird/defaults/pref/ -rw-r--r-- root/root 245 2019-03-17 15:05 ./usr/share/thunderbird/defaults/pref/channel-prefs.js -rw-r--r-- root/root 73 2018-08-16 17:03 ./usr/share/thunderbird/defaults/pref/vendor.js lrwxrwxrwx root/root 0 2019-03-17 15:05 ./usr/share/thunderbird/defaults/syspref -> /etc/thunderbird/pref