Project

General

Profile

Bug #15973

APT pinning broken for stretch-backports

Added by segfault 10 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
09/23/2018
Due date:
% Done:

100%

Feature Branch:
segfault:bugfix/15973-fix-backports-apt-pinning
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

The APT pinning for stretch-backports is ignored, because we set the origin to "Debian" instead of "Debian Backports". I see that this was done on purpose in 8efc9e33, because our snapshots repo uses "Debian" as its origin. But in config/chroot_local-includes/lib/live/config/1500-reconfigure-APT, we change the repo to the official Debian repo, which uses "Debian Backports" as the origin for backports.

I see two solutions: Use a different archive for backports in our repo, which uses "o=Debian Backports". Or replace the origin for the backport pins in config/chroot_local-includes/lib/live/config/1500-reconfigure-APT.


Related issues

Blocked by Tails - Bug #15837: APT is not configured to install packages from our repo Resolved 08/24/2018
Blocks Tails - Feature #15334: Core work 2018Q3: Foundations Team Resolved 02/20/2018

Associated revisions

Revision ec50ebb2 (diff)
Added by segfault 10 months ago

Fix regex (refs #15973)

Revision 9fb81395 (diff)
Added by segfault 10 months ago

Fix another regex (refs: #15973)

Revision a01a23f9
Added by intrigeri 10 months ago

Merge branch 'bugfix/15973-fix-backports-apt-pinning' into stable (Fix-committed: #15973)

History

#1 Updated by segfault 10 months ago

  • Target version set to Tails_3.10.1

#2 Updated by segfault 10 months ago

  • Assignee set to segfault

I would like to take this one.

#3 Updated by segfault 10 months ago

  • Assignee changed from segfault to intrigeri
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/15973-fix-backports-apt-pinning

#4 Updated by segfault 10 months ago

  • Blocked by Bug #15837: APT is not configured to install packages from our repo added

#5 Updated by segfault 10 months ago

  • Feature Branch changed from bugfix/15973-fix-backports-apt-pinning to segfault:bugfix/15973-fix-backports-apt-pinning

I based the branch on bugfix/15837-fix-apt-preferences, so #15837 should be merged before this one.

#6 Updated by intrigeri 10 months ago

  • Assignee changed from intrigeri to segfault
  • QA Check changed from Ready for QA to Dev Needed

I believe [a,n] does not do what you think it does: this "character class" will match any single char among "a", "n" (so far so good)… and "," (incorrect).

#7 Updated by intrigeri 10 months ago

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 50

#8 Updated by intrigeri 10 months ago

This being said: good catch and thanks for cleaning up after me :)

#9 Updated by segfault 10 months ago

  • Assignee changed from segfault to intrigeri
  • QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:

I believe [a,n] does not do what you think it does: this "character class" will match any single char among "a", "n" (so far so good)… and "," (incorrect).

Fixed in ec50ebb27690ee08f3b78ac7727edb23a35e2eb8.

#10 Updated by intrigeri 10 months ago

  • % Done changed from 50 to 70

Code review passes, will now test!

#11 Updated by intrigeri 10 months ago

#12 Updated by intrigeri 10 months ago

  • Assignee changed from intrigeri to segfault
  • QA Check changed from Ready for QA to Dev Needed

intrigeri wrote:

Code review passes

Actually not: d4bd6d00f5d912a0e701a1e849b85b7a2a2b4a1f introduces a regression in the "Custom APT repository" regexp. deb[.]tails[.]boum[.]org was correct but deb.tails.boum.org matches e.g. debXtailsYboumZorg, which it should not.

#13 Updated by segfault 10 months ago

  • Assignee changed from segfault to intrigeri
  • QA Check changed from Dev Needed to Ready for QA

argh, how can i suck so hard at parsing regex. fixed in 9fb81395ae4d8b03ce6d944895240ca4ee2fae4d.

#14 Updated by intrigeri 10 months ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 70 to 100
  • QA Check changed from Ready for QA to Pass

segfault wrote:

argh, how can i suck so hard at parsing regex.

You're learning :)

fixed in 9fb81395ae4d8b03ce6d944895240ca4ee2fae4d.

Merged!

#15 Updated by intrigeri 10 months ago

  • Target version changed from Tails_3.10.1 to Tails_3.9.1

#16 Updated by segfault 9 months ago

  • Status changed from Fix committed to In Progress

#17 Updated by intrigeri 9 months ago

  • Status changed from In Progress to Fix committed

#18 Updated by anonym 9 months ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF