Project

General

Profile

Bug #15854

Re-add UID/GID stability checks on feature/buster

Added by hefee about 1 year ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
08/27/2018
Due date:
% Done:

100%

Feature Branch:
bugfix/15690-stop-installing-all-priority-standard-packages
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

As the base system changes to much with buster - the underlying system groups also changes, so we can't keep the GIDs from further versions.
At the moment we just remove the script, t get the iso being build.


Related issues

Related to Tails - Bug #16322: Polish 04-change-gids-and-uids code style Resolved 01/08/2019
Blocked by Tails - Bug #15690: Stop installing all "Priority: standard" packages only to remove some of them later Resolved 06/29/2018

Associated revisions

Revision f2f255e1 (diff)
Added by intrigeri 10 months ago

Update expected /etc/passwd for Buster (refs: #15854)

Revision 3f6e4a9d (diff)
Added by intrigeri 10 months ago

Update expected /etc/group for Buster (refs: #15854)

Revision 07a04387 (diff)
Added by intrigeri 10 months ago

Re-introduce 04-change-gids-and-uids hook (refs: #15854)

We won't need it for Tails 4.0 but we'll probably need it later
in the 4.x cycle. So let's bring the functions back but not call
them for now.

Revision eaeb426f
Added by intrigeri 10 months ago

Merge branch 'bugfix/15690-stop-installing-all-priority-standard-packages' into feature/buster

Closes: #15690, #15854

History

#1 Updated by intrigeri about 1 year ago

  • Status changed from New to Confirmed

#2 Updated by intrigeri about 1 year ago

  • Related to Bug #15689: Test if overlayfs is affected by the DAC bug wrt. incremental upgrades changing UID/GID added

#3 Updated by intrigeri about 1 year ago

  • Related to deleted (Bug #15689: Test if overlayfs is affected by the DAC bug wrt. incremental upgrades changing UID/GID)

#4 Updated by intrigeri about 1 year ago

  • Blocked by Bug #15689: Test if overlayfs is affected by the DAC bug wrt. incremental upgrades changing UID/GID added

#5 Updated by intrigeri 10 months ago

The purpose of this script is to avoid breaking automatic (incremental) upgrades. There will be no incremental upgrade from Tails 3.x to 4.0 so it's fine if the UIDs and GIDs change in 4.0. But later on, if UIDs/GIDs change in a version after 4.0, config/chroot_local-hooks/99-zzz_check_uids_and_gids needs to spot the problem and 04-change-gids-and-uids needs to fix it. So I would recommend this course of action:

  • bring back config/chroot_local-hooks/99-zzz_check_uids_and_gids on feature/buster
  • update /usr/share/tails/build/{passwd,group} on feature/buster so this check passes
  • bring back 04-change-gids-and-uids on feature/buster, make it a no-op for now (we don't need it in 4.0 so no need to call any of the functions in that file) but keep the relevant code and comments around so they're handily available next time we need them

#6 Updated by intrigeri 10 months ago

  • Subject changed from Decide what to do with 04-change-gids-and-uids to Re-add UID/GID stability checks on feature/buster

#7 Updated by intrigeri 10 months ago

  • Blocked by Bug #15690: Stop installing all "Priority: standard" packages only to remove some of them later added

#8 Updated by intrigeri 10 months ago

  • Assignee set to intrigeri
  • Feature Branch set to bugfix/15690-stop-installing-all-priority-standard-packages

#9 Updated by intrigeri 10 months ago

  • Status changed from Confirmed to In Progress

#10 Updated by intrigeri 10 months ago

  • Assignee changed from intrigeri to CyrilBrulebois
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA

#11 Updated by intrigeri 10 months ago

  • Blocked by deleted (Bug #15689: Test if overlayfs is affected by the DAC bug wrt. incremental upgrades changing UID/GID)

#12 Updated by hefee 10 months ago

  • Assignee changed from CyrilBrulebois to hefee

#13 Updated by hefee 10 months ago

  • Assignee changed from hefee to intrigeri
  • % Done changed from 50 to 80
  • QA Check changed from Ready for QA to Dev Needed
updated passwd and groups are tested by Jenkins anyways. So I don't check those additionally.
The 04-change-gids-and-uids looks fine just nip-picking:
  • add a comment on the top, how to use this script / what it is doing and comments for each function, what it does and how to use it.
  • don't mix ${var} with $var
  • recommend to use CAPS variable names for arguments and lowercase for local variables.

#14 Updated by intrigeri 10 months ago

  • QA Check changed from Dev Needed to Pass
updated passwd and groups are tested by Jenkins anyways. So I don't check those additionally.
The 04-change-gids-and-uids looks fine just nip-picking:
  • add a comment on the top, how to use this script / what it is doing and comments for each function, what it does and how to use it.
  • don't mix ${var} with $var
  • recommend to use CAPS variable names for arguments and lowercase for local variables.

Good ideas. IMO this should be done on a branch forked off devel (no reason to carry it as part of the devel...feature/buster delta) ⇒ filed #16322 to track this.

#15 Updated by intrigeri 10 months ago

  • Related to Bug #16322: Polish 04-change-gids-and-uids code style added

#16 Updated by intrigeri 10 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 80 to 100

#17 Updated by intrigeri 10 months ago

  • Assignee deleted (intrigeri)

Also available in: Atom PDF