Project

General

Profile

Bug #15841

"Totem could not display the help contents"

Added by segfault 4 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
08/25/2018
Due date:
% Done:

100%

QA Check:
Pass
Feature Branch:
segfault:bugfix/15841-allow-yelp-in-totem
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

The AppArmor profile for GNOME Videos aka Totem doesn't allow executing /usr/bin/yelp, which causes the following error message when trying to open the help in Totem:

Totem could not display the help contents
Failed to execute child process "yelp" (Permission denied)

I tested this on 3.8 and 3.9~rc1 and both are affected.


Related issues

Blocked by Tails - Bug #15821: Video playback broken on some Intel graphics cards (regression in 3.9~rc1) Resolved 08/20/2018

Associated revisions

Revision e46fbd4b (diff)
Added by segfault 3 months ago

Totem AppArmor profile: backport fix to allow access to yelp (refs: #15841)

Revision 07fe1f44
Added by intrigeri 3 months ago

Merge remote-tracking branch 'segfault/bugfix/15841-allow-yelp-in-totem' into stable (Fix-committed: #15841)

History

#1 Updated by segfault 4 months ago

  • Assignee set to intrigeri
  • QA Check set to Info Needed

It works after applying the following patch to the AppArmor profile:

--- usr.bin.totem.orig    2018-08-25 13:53:20.600000000 +0000
+++ usr.bin.totem    2018-08-25 13:47:15.392000000 +0000
@@ -9,11 +9,13 @@
   #include <abstractions/ibus>
   #include <abstractions/python>
   #include <abstractions/totem>
+  #include <abstractions/ubuntu-helpers>

   # Maybe in an abstraction?
   /usr/include/**/pyconfig.h r,

   /usr/bin/totem r,
+  /usr/bin/yelp Cx -> sanitized_helper,
   /usr/bin/totem-video-thumbnailer Pix,
   /usr/lib/@{multiarch}/libtotem-plparser[0-9]*/totem-pl-parser/* ix,
   /dev/sr* r,

I guess we should upstream this, right?

#2 Updated by intrigeri 4 months ago

  • Assignee changed from intrigeri to segfault
  • QA Check deleted (Info Needed)

#3 Updated by intrigeri 4 months ago

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10

#4 Updated by intrigeri 4 months ago

  • Blocked by Bug #15821: Video playback broken on some Intel graphics cards (regression in 3.9~rc1) added

#5 Updated by intrigeri 4 months ago

Please base your work on my branch for #15821 otherwise it'll be painful to merge.

#6 Updated by segfault 3 months ago

  • Feature Branch set to bugfix/15841-allow-yelp-in-totem

#7 Updated by segfault 3 months ago

  • Target version changed from Tails_3.9 to Tails_3.10.1

#8 Updated by segfault 3 months ago

  • Assignee changed from segfault to intrigeri
  • QA Check set to Ready for QA

#9 Updated by intrigeri 3 months ago

  • Feature Branch changed from bugfix/15841-allow-yelp-in-totem to segfault:bugfix/15841-allow-yelp-in-totem

#10 Updated by intrigeri 3 months ago

  • % Done changed from 10 to 60

Code review passes, now waiting for CI results.

#11 Updated by intrigeri 3 months ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 60 to 100
  • QA Check changed from Ready for QA to Pass

Merged!

#12 Updated by intrigeri 2 months ago

  • Target version changed from Tails_3.10.1 to Tails_3.9.1

#13 Updated by anonym 2 months ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF