Project

General

Profile

Feature #15803

Upgrade Tor Browser to 8.0a10

Added by intrigeri 11 months ago. Updated 11 months ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
-
Target version:
Start date:
08/18/2018
Due date:
% Done:

100%

Estimated time:
1.00 h
Feature Branch:
feature/15803-tor-browser-8.0a10+force-all-tests
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Browser

Description

It's not the final 8.0 but better detect now any breakage or adjustment we need to do on our side.


Related issues

Blocks Tails - Feature #15334: Core work 2018Q3: Foundations Team Resolved 02/20/2018
Blocks Tails - Bug #15706: Tor Browser 8 always prompts wrt. asking webpages in English Resolved 07/03/2018
Blocks Tails - Bug #15801: The Tor Browser 8.0a9 icon (overview, taskbar) is uglier than it used to be Resolved 08/17/2018
Blocks Tails - Bug #15805: Update doc for Tor Browser 8 Resolved 08/18/2018

Associated revisions

Revision b61d81a9 (diff)
Added by intrigeri 11 months ago

Upgrade Tor Browser to 8.0a10-build5 (refs: #15803, #15706).

Revision 6b321a7f (diff)
Added by intrigeri 11 months ago

Adjust to the fact Tor Browser 8.0a10 replaces firefox with a wrapper (refs: #15803).

Their new wrapper conditionally (more on that later) adds their own libstdc++6
to LD_LIBRARY_PATH, which our wrapper already does.

Revision 97556aae (diff)
Added by intrigeri 11 months ago

Tor Browser: don't use the bundled copy of libstdc++.so.6, ours is recent enough (refs: #15803).

This mimics Tor Browser upstream's new behaviour: it will now use its bundled
libstdc++.so.6 iff. the system copy is too old. Let's not bother running their
abicheck program at runtime though: instead, update our doc to ensure we switch
back to the bundled copy of that library when needed.

Revision 4d57ce5a (diff)
Added by intrigeri 11 months ago

Browser spellchecker: take new Tor Browser locales into account (refs: #15803).

Note that I'm not installing the dictionaries for these languages: the
cost/benefit is unclear to me and at some point we need to sort out which
languages we install dictionaries for by default… or not. I've filed #15807 so
we keep track of this problem.

Revision ceae24fd (diff)
Added by intrigeri 11 months ago

Test suite: fix Tor Launcher binary path (refs: #15803).

It's firefox-unconfined, not firefox.real-unconfined.

Revision 0230d3c6 (diff)
Added by intrigeri 11 months ago

Test suite: adjust to the fact "New Circuit for this Site" is now in the site information and not under the Torbutton anymore (refs: #15803).

Revision efcbcb65 (diff)
Added by intrigeri 11 months ago

Tor Browser release process: clarify what to do on required libstdc++6 version bumps (refs: #15803).

Revision efa6c024
Added by intrigeri 11 months ago

Merge branch 'feature/15803-tor-browser-8.0a10+force-all-tests' into testing (Fix-committed: #15803, #15706, #15801)

History

#1 Updated by intrigeri 11 months ago

  • Description updated (diff)

#2 Updated by intrigeri 11 months ago

#3 Updated by intrigeri 11 months ago

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10
  • Feature Branch set to feature/15803-tor-browser-8.0a10+force-all-tests

#4 Updated by intrigeri 11 months ago

  • Blocks Bug #15706: Tor Browser 8 always prompts wrt. asking webpages in English added

#5 Updated by intrigeri 11 months ago

  • Blocks Bug #15801: The Tor Browser 8.0a9 icon (overview, taskbar) is uglier than it used to be added

#6 Updated by intrigeri 11 months ago

  • Blocks Bug #15805: Update doc for Tor Browser 8 added

#7 Updated by intrigeri 11 months ago

Note to myself:

16:01:43 The following supported browser locales lack descriptions in /usr/share/tails/browser-localization/descriptions: ca ga-IE id is nb-NO
16:01:43 E: config/chroot_local-hooks/11-localize_browser failed (exit non-zero). You should check for errors.

#8 Updated by intrigeri 11 months ago

  • Assignee changed from intrigeri to segfault
  • % Done changed from 10 to 50
  • Estimated time set to 1.00 h
  • QA Check set to Ready for QA

Note: it fixes #15777 for NoScript :)

#9 Updated by segfault 11 months ago

I reviewed the code and have the following notes:

97556aaed14dca855269709ae753ebcf02cf3bf8:

  • The release doc doesn't say what to do if the glibc version changed
  • Why don't we use Tor Browser's abicheck in chroot_local-hooks/10-tbb to determine whether to use the system libc?

I want to build and test the branch, but can't do that right now.

#10 Updated by intrigeri 11 months ago

I reviewed the code

Thank you!

97556aaed14dca855269709ae753ebcf02cf3bf8:

  • The release doc doesn't say what to do if the glibc version changed

Right. Fixed in efcbcb65322860a471c5068f32c92d79eb446663.

  • Why don't we use Tor Browser's abicheck in chroot_local-hooks/10-tbb to determine whether to use the system libc?

I'm not confident a check done in 10-tbb will always be reliable: sometimes we install/upgrade stuff in later hooks. So the only way to use that abicheck program would be at runtime and then it gets a bit too complicated IMO. Now, I think it's too early to tell what will work for us, so I'd rather do the simpler thing now (as my branch does) and if this causes maintenance trouble in the future, it'll still be time to change our mind and use their abicheck. Fair enough?

#11 Updated by segfault 11 months ago

intrigeri wrote:

Right. Fixed in efcbcb65322860a471c5068f32c92d79eb446663.

Great

  • Why don't we use Tor Browser's abicheck in chroot_local-hooks/10-tbb to determine whether to use the system libc?

I'm not confident a check done in 10-tbb will always be reliable: sometimes we install/upgrade stuff in later hooks.

I see. Maybe we could do it in a separate 99- hook.

So the only way to use that abicheck program would be at runtime and then it gets a bit too complicated IMO. Now, I think it's too early to tell what will work for us, so I'd rather do the simpler thing now (as my branch does) and if this causes maintenance trouble in the future, it'll still be time to change our mind and use their abicheck. Fair enough?

Sure

#12 Updated by segfault 11 months ago

  • Assignee changed from segfault to intrigeri
  • QA Check changed from Ready for QA to Pass

I want to build and test the branch, but can't do that right now.

Done, everything looking good.

Note: it fixes #15777 for NoScript :)

Indeed, that's great! HTTPS Everywhere is still affected, but I think that is less of a problem.

#13 Updated by intrigeri 11 months ago

  • Assignee changed from intrigeri to segfault
  • % Done changed from 50 to 90
  • QA Check changed from Pass to Ready for QA

Great, thanks! But before I merge the branch I need your QA on #15706 and #15801. Did you do them at the same time already?

#14 Updated by segfault 11 months ago

  • QA Check changed from Ready for QA to Pass

intrigeri wrote:

Great, thanks! But before I merge the branch I need your QA on #15706 and #15801. Did you do them at the same time already?

I tested #15801 at the same time already, and now also tested #15706

#15 Updated by intrigeri 11 months ago

I tested #15801 at the same time already, and now also tested #15706

Thanks a lot!

#16 Updated by intrigeri 11 months ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (segfault)
  • % Done changed from 90 to 100

#17 Updated by sajolida 11 months ago

I don't dare opening a new ticket for that and assume that you're on the case already but in a recent testing image (31c1a8c646) I still have JavaScript disabled by default.

I showed you that some days ago and I understand that it was related to this issue.

#18 Updated by intrigeri 11 months ago

I don't dare opening a new ticket for that and assume that you're on the case already but in a recent testing image (31c1a8c646) I still have JavaScript disabled by default.

I'm not on the case already and without a ticket, this totally slipped off my radar. In the future please file tickets for such critical issues (you dare filing tickets for much less critical ones, which is good, and I encourage you to do the same for potential release blockers :)
I've filed #15905 about this.

#19 Updated by intrigeri 11 months ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF