Project

General

Profile

Bug #15802

Feature #14568: Additional Software Packages

New ASP code breaks creating new empty persistence config files when permissions are incorrect

Added by intrigeri 9 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
Persistence
Target version:
Start date:
08/17/2018
Due date:
% Done:

100%

QA Check:
Pass
Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Additional Software Packages

Description

The fix for #15781 (f7c31127c5b039f03414fae1c63c4be21b6cc3e4) changed the API of disable_and_create_empty_persistence_conf_file and create_empty_persistence_conf_file to fix the bug I had reported, but it did not update all callers of these functions accordingly, so at least 3 of them are now broken: they're going to call install --mode "" which won't work.

Please review all users of the function you've modified and adjust them. Or give these functions safe defaults back, that your specific use case can override.

This is a blocker for 3.9.

Associated revisions

Revision 184e1711 (diff)
Added by alant 9 months ago

ASP: set safe defaults for disable_and_create_empty_persistence_conf_file

Will-fix: #15802

Revision 3806bec3 (diff)
Added by alant 9 months ago

ASP: set safe defaults for disable_and_create_empty_persistence_conf_file

Will-fix: #15802

Revision 31c1a8c6
Added by intrigeri 9 months ago

Fix regression in 3.9~rc1: New ASP code breaks creating new empty persistence config files when permissions are incorrect (refs: #15802)

History

#1 Updated by alant 9 months ago

I'll do that shortly.

#2 Updated by u 9 months ago

Seems this is the only big blocker right now.

#3 Updated by alant 9 months ago

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 20
  • QA Check set to Ready for QA

#5 Updated by alant 9 months ago

  • Assignee changed from alant to segfault
  • % Done changed from 20 to 40

#6 Updated by segfault 9 months ago

  • Assignee changed from segfault to alant
  • QA Check changed from Ready for QA to Pass

LGTM

#7 Updated by intrigeri 9 months ago

  • Assignee changed from alant to intrigeri

Thanks! I'll take one last look and will merge.

#8 Updated by intrigeri 9 months ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 40 to 100

Merged and wrote a merge commit message that describes what the problem we're fixing is (instead of merely paraphrasing the diff).

#9 Updated by intrigeri 9 months ago

  • Status changed from Fix committed to In Progress

#10 Updated by intrigeri 9 months ago

  • Status changed from In Progress to Fix committed

#11 Updated by intrigeri 9 months ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF