Project

General

Profile

Feature #15793

Improve ownership test in tails-debugging-info

Added by segfault about 1 year ago. Updated 5 months ago.

Status:
Confirmed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
08/15/2018
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

Currently, we only print a warning if the file that is going to be printed by tails-debugging-info is not owned by the user that was configured in /etc/whisperback/debugging-info.json.

We could improve it by:
  • Also checking whether the file is a symlink that is not owned by the correct user
  • Also check all the parent directories

See https://labs.riseup.net/code/issues/8514#note-58 for a proposed patch for the first point.

Additionally, since we ported tails-debugging-info to Python, we always open the file to be printed as root, while before we opened it as the user which is now configured in /etc/whisperback/debugging-info.json. We should fix that.


Related issues

Related to Tails - Feature #8514: Replace WhisperBack.mail_appended_info with a dictionary Resolved 01/02/2015

History

#1 Updated by segfault about 1 year ago

  • Related to Feature #8514: Replace WhisperBack.mail_appended_info with a dictionary added

#2 Updated by segfault about 1 year ago

  • Description updated (diff)

#3 Updated by CyrilBrulebois 9 months ago

  • Target version changed from Tails_3.11 to Tails_3.12

#4 Updated by anonym 8 months ago

  • Target version changed from Tails_3.12 to Tails_3.13

#5 Updated by CyrilBrulebois 6 months ago

  • Target version changed from Tails_3.13 to Tails_3.14

#6 Updated by segfault 5 months ago

  • Target version deleted (Tails_3.14)

Also available in: Atom PDF