Project

General

Profile

Bug #15727

Please make it more obvious that the .orig file check is fatal

Added by lamby about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Low
Assignee:
-
Category:
Build system
Target version:
Start date:
07/13/2018
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

When patches are fuzzy and leave .orig files around, we bail out of the build. However, without some kind of "error" / "fatal" or even "E:" prefix it is not obvious whether this a warning or a fatal error.

Trivial patch attached that uses E: to match the live-build style.

foo.diff View (637 Bytes) lamby, 07/13/2018 11:06 AM

Associated revisions

Revision a0aef694 (diff)
Added by intrigeri about 1 year ago

Make it more obvious that the .orig file check is fatal (refs: #15727)

Thanks to Chris Lamb for the patch.

History

#1 Updated by intrigeri about 1 year ago

  • Status changed from New to In Progress
  • Target version set to Tails_3.9

#2 Updated by intrigeri about 1 year ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 0 to 100
  • QA Check changed from Ready for QA to Pass

Applied on stable then merged into devel. Thanks!

Note that we have quite a few other similar "print error and then exit != 0" in hooks but that's no reason not to improve things incrementally.

#3 Updated by intrigeri about 1 year ago

  • Status changed from Fix committed to In Progress

#4 Updated by intrigeri about 1 year ago

  • Status changed from In Progress to Fix committed

#5 Updated by intrigeri about 1 year ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF