Project

General

Profile

Bug #15493

Feature #11834: Migrate our infrastructure to Puppet 4

Adjust monitoring check for Puppet runs for Puppet master 4.x

Added by intrigeri over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Infrastructure
Target version:
Start date:
04/06/2018
Due date:
% Done:

100%

Feature Branch:
Type of work:
Sysadmin
Blueprint:
Starter:
Affected tool:

Description

/var/lib/puppet/yaml/node/*.yaml don't contain any "expiration" line anymore, so this code:

    EXPIRATION=$(grep -m1 expiration ${YAMLPATH}/$node.yaml | awk '{printf("%s %s", $2, $3);}')
    typeset -i CHECKIN=$(date +"%s" -d "${EXPIRATION}")
    DIFFERENCE=$((${NOW} - ${CHECKIN}))

… will set EXPIRATION= and then date +"%s" -d "" means "today at 00:00:00" so DIFFERENCE will always be less than 24 hours => this check will always pass regardless of the status of agent runs.


Related issues

Blocks Tails - Feature #13284: Core work: Sysadmin (Adapt our infrastructure) Confirmed 06/30/2017

History

#1 Updated by intrigeri over 1 year ago

  • Blocks Feature #13284: Core work: Sysadmin (Adapt our infrastructure) added

#2 Updated by intrigeri over 1 year ago

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10

Options I've found:

#3 Updated by intrigeri over 1 year ago

  • % Done changed from 10 to 20

intrigeri wrote:

Options I've found:

Sent a pull request.

Sent a pull request.

It now works fine so I'll port our existing (currently broken) check to check_puppetdb_nodes.

#4 Updated by intrigeri over 1 year ago

  • Assignee changed from intrigeri to groente
  • % Done changed from 20 to 50
  • QA Check set to Ready for QA

Seems to work fine: https://icingaweb2.tails.boum.org/monitoring/host/services?host=puppet-git.lizard#!/monitoring/service/show?host=puppet-git.lizard&service=puppet-git.lizard

See 5d3858bcb95a6b9be0a293dd7acbd58d6e15f80a..17b0eee41fea1708d3ae3685886db2ab13aa154d in our manifests repo + of course the submodule updates this revision range includes.

#5 Updated by groente over 1 year ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

looks good!

Also available in: Atom PDF