Project

General

Profile

Bug #15468

Make the WhisperBack reports more helpdesk-friendly

Added by goupille almost 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
03/28/2018
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Yes
Affected tool:
WhisperBack

Description

by default, if, in the body of an email, there is a line like this one :

-- 

("-- "), Thunderbird see the rest of the message as a signature. unfortunately there is a line like that in the whisperback reports, so it doesn't quote it when replying. That make it uneasy to forward the logs to FT or to point the user to some parts of the logs.

We should empty those lines e.g. s/^--\s*//. The mail_appended_info function in source:config/chroot_local-includes/etc/whisperback/config.py is probably the best place to do that.

This change be initially tested without building a Tails ISO: patch code in a running Tails and send a bug report that asks our help desk to confirm whether it's better for them.

0001-bug-15468-Make-the-WhisperBack-reports-more-helpdesk.patch View (1.18 KB) sascha.markus@gmail.com, 05/16/2018 11:45 AM

0001-bugfix-15468-make-reports-helpdesk-friendly.patch View (1.17 KB) sascha.markus@gmail.com, 05/28/2018 07:35 PM


Related issues

Blocks Tails - Feature #15139: Core work 2018Q2: Foundations Team Resolved 01/01/2018

Associated revisions

Revision 600f28a6 (diff)
Added by sascha.markus over 1 year ago

Ensure debugging info in Whisperback reports don't contain email signature markers (Fix-committed: #15468)

… otherwise email clients tend to drop all the text after the first
such marker when replying to, or forwarding, such a report.

History

#1 Updated by intrigeri almost 2 years ago

  • Description updated (diff)

#2 Updated by intrigeri almost 2 years ago

#3 Updated by intrigeri almost 2 years ago

  • Description updated (diff)
  • Starter set to Yes

Let's see if the FT has time for that in Q2.

#4 Updated by intrigeri almost 2 years ago

  • Assignee deleted (intrigeri)
  • Type of work changed from Research to Code

#5 Updated by intrigeri almost 2 years ago

  • Subject changed from make the Whisperback reports more helpdesk friendly to Make the WhisperBack reports more helpdesk-friendly

#6 Updated by intrigeri almost 2 years ago

  • Description updated (diff)

#7 Updated by intrigeri almost 2 years ago

  • Assignee set to CyrilBrulebois
  • Target version set to Tails_3.7
  • Estimated time set to 1.00 h

#8 Updated by bertagaz over 1 year ago

  • Target version changed from Tails_3.7 to Tails_3.8

#9 Updated by goupille over 1 year ago

I'm a bit confused about the reply email address on the bug report we received, but it is definitely more helpdesk friendly, thanks !

#10 Updated by sascha.markus@gmail.com over 1 year ago

Well, I used my mail address in case you would reply to it. :-)

Here is the patch I used to send the error report.

#11 Updated by intrigeri over 1 year ago

  • Status changed from Confirmed to In Progress
  • Assignee changed from CyrilBrulebois to sascha.markus@gmail.com
  • % Done changed from 0 to 30
  • re.sub(r'--\s', '' is too broad IMO: any reason not to anchor this with ^ as suggested in the ticket description?
  • Note that this ticket was assigned to Cyril. In the future, when working on a ticket that's already assigned to someone, please coordinate with them in order to avoid duplicated work :)
  • This being said, well, what's done is done, Cyril has plenty of other Tails work on his plate, and you're pretty close to a mergeable fix, so if you could complete this work in time for the 3.8 release (deadline: June 19), it would be sweet!

#12 Updated by sascha.markus@gmail.com over 1 year ago

Here is a new patch using the regex from the bug description.

I'll get in touch with the assignee next time.

#13 Updated by intrigeri over 1 year ago

  • Estimated time deleted (1.00 h)
  • QA Check set to Ready for QA

#14 Updated by intrigeri over 1 year ago

  • Status changed from In Progress to 11
  • Assignee deleted (intrigeri)
  • % Done changed from 30 to 100
  • QA Check changed from Ready for QA to Pass

Applied to stable & devel after wring an actual commit message. Thanks!

#15 Updated by intrigeri over 1 year ago

  • Target version changed from Tails_3.8 to Tails_3.7.1

#16 Updated by intrigeri over 1 year ago

  • Assignee set to BitingBird

#17 Updated by intrigeri over 1 year ago

  • Assignee deleted (BitingBird)

#18 Updated by intrigeri over 1 year ago

  • Status changed from 11 to Resolved

Also available in: Atom PDF