Project

General

Profile

Feature #15466

Feature #14540: Survey platform

No notifications from LimeSurvey since LimeSurvey 2.72.2 (November 10)

Added by sajolida over 1 year ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
03/27/2018
Due date:
% Done:

0%

Feature Branch:
Type of work:
Sysadmin
Blueprint:
Starter:
Affected tool:

Description

See #14828#note-14: I got a notification for 2.72.2 on October 30 and 2.72.3 on November 10.

I never got a notification for 2.72.4 which, according to the release notes was released on November 10. Note that the commit for 2.72.3 on the release notes dates from December 22 (8f5846c8d3) which is weird...

Since then there has been numerous releases, some including security issues and I got no notification at all.

Making this as part of #14540 since it has been broken since #14828.

History

#1 Updated by intrigeri about 1 year ago

  • Target version set to Tails_3.11

Ouch, this got off my radar :/ I'll try to take care of this by the end of the year but it'll heavily depend on how much of anonym's work I manage to offload to other people.

#2 Updated by intrigeri 10 months ago

  • Target version changed from Tails_3.11 to Tails_3.12

#3 Updated by intrigeri 8 months ago

  • Target version changed from Tails_3.12 to Tails_3.13

I've booked some time mid-February for a sysadmin sprint. I'll try to make this one fit.

#4 Updated by sajolida 6 months ago

I might have good news for you! Today I tried to update LimeSurvey and noticed that the 'origin' repo (/var/lib/limesurvey/git) was not updated and is still on October 2017, 2.72.3+171020 which is also the lastest version for which I had a notification.

Maybe that's why I didn't get any more notifications.

#5 Updated by intrigeri 6 months ago

  • Assignee changed from intrigeri to sajolida
  • QA Check set to Ready for QA

I might have good news for you! Today I tried to update LimeSurvey and noticed that the 'origin' repo (/var/lib/limesurvey/git) was not updated and is still on October 2017, 2.72.3+171020 which is also the lastest version for which I had a notification.

Maybe that's why I didn't get any more notifications.

Thanks a lot, this put me straight on the right track! I think I've fixed it. You should receive an email notification around 12:27 UTC today.

#6 Updated by intrigeri 6 months ago

  • Status changed from Confirmed to In Progress
  • Assignee changed from sajolida to intrigeri
  • QA Check deleted (Ready for QA)

#7 Updated by intrigeri 6 months ago

  • Assignee changed from intrigeri to sajolida
  • QA Check set to Ready for QA

#8 Updated by sajolida 6 months ago

  • Assignee changed from sajolida to intrigeri

I did receive a notification on 12:27 but it was not formatted in a way that referenced any new version (like the ones I received in 2017). Here is what I received:

>From https://github.com/LimeSurvey/LimeSurvey
   b38fd980a1..97750a52db  master               -> master
 + 6ff5f709b4...960aefc98d refs/pull/1204/merge -> refs/pull/1204/merge  (forced update)
 + f16dfec800...826148e374 refs/pull/1218/merge -> refs/pull/1218/merge  (forced update)
 + 4fd8e6c69e...45a38b30d6 refs/pull/1242/merge -> refs/pull/1242/merge  (forced update) at /var/lib/limesurvey/monitor-releases/git/bin/../lib/Tails/LimeSurvey/MonitorReleases.pm line 180.

Is this expected?

#9 Updated by intrigeri 6 months ago

  • QA Check changed from Ready for QA to Dev Needed

#10 Updated by sajolida 6 months ago

I got another one today:

>From https://github.com/LimeSurvey/LimeSurvey
   b38fd980a1..97750a52db  master               -> master
 + 6ff5f709b4...960aefc98d refs/pull/1204/merge -> refs/pull/1204/merge  (forced update)
 + f16dfec800...826148e374 refs/pull/1218/merge -> refs/pull/1218/merge  (forced update)
 + 4fd8e6c69e...45a38b30d6 refs/pull/1242/merge -> refs/pull/1242/merge  (forced update) at /var/lib/limesurvey/monitor-releases/git/bin/../lib/Tails/LimeSurvey/MonitorReleases.pm line 180.

Maybe you could send the notifications to your email until they are working fine? That would reduce the lately and overhead in communications.

Also, I subscribed to the release announcement on the upstream GitHub: https://github.com/LimeSurvey/LimeSurvey/releases. I discovered this feature for the Forge library of the verification extension and haven't thought about doing that earlier for LimeSurvey.

#11 Updated by intrigeri 6 months ago

Maybe you could send the notifications to your email until they are working fine? That would reduce the lately and overhead in communications.

Good idea ⇒ done!

#12 Updated by intrigeri 6 months ago

  • QA Check changed from Dev Needed to Ready for QA

I think I've fixed the remaining bugs. Let's see if I get a notification.

#13 Updated by intrigeri 6 months ago

  • Assignee changed from intrigeri to sajolida

Works fine now! I've reset the "last checked tag" to the latest version you've been notified about so you should get a notification about plenty of new releases at 16:27 UTC today (i.e. exactly the notification I've just received). And then you should only receive notifications for releases newer than 3.15.9.

#14 Updated by sajolida 6 months ago

  • Status changed from In Progress to Resolved
  • Assignee deleted (sajolida)
  • QA Check deleted (Ready for QA)

I got one indeed! Excellent!

#15 Updated by sajolida 6 months ago

  • Assignee set to intrigeri
  • QA Check set to Dev Needed

I'm receiving this message every 8 hours now:

The last version in the release notes (3.16.0) is different from the newest tag (3.16.1+190225, version 3.16.1) at /var/lib/limesurvey/monitor-releases/git/bin/tails-monitor-limesurvey-releases line 11.

#16 Updated by intrigeri 6 months ago

  • Status changed from Resolved to In Progress
  • Assignee changed from intrigeri to sajolida
  • QA Check changed from Dev Needed to Ready for QA

tl;dr: upstream messed up their release, yay, yet another class of mistakes of theirs that this code needs to cope with. Hopefully done on my side ⇒ you should receive the expected notification around 16:27 UTC today:

Newest tag: 3.16.1+190225
Last tagged version: 3.16.1
Last checked tag: 3.15.9+190214
Last checked version: 3.15.9
Last release in changelog: 3.16.1
New release (3.16.1) fixes security issues:
- -[security] Fixed issue #14617: relative path allowed in lsa multiple download (LouisGac)
The latest release is 3.16.1

Now comes the explanation.

This is the result of a sanity check which is meant to ensure the notification system doesn't erroneously take note of "I've checked for security issues up to version X" while it could not actually do so. In the case at hand, indeed the system could only check up to 3.16.0, and not 3.16.1, because it's looking at release notes in the last tagged release, but LimeSurvey upstream messed up their last release in several ways:

  • The tag should be 3.16.1+190314 but instead it's named 3.16.1+190225. I don't think that's a problem for this piece of code in itself (it's not the first time they do this mistake and it seems that our code is ready to deal with that just fine).
  • That tag points to a commit whose last changelog entry is about 3.16.0 (build 190225): git show 3.16.1+190225:docs/release_notes.txt, which explains the error message we're seeing.

This was reported upstream (https://bugs.limesurvey.org/view.php?id=14619).

The limesurvey3.16.1+190314.tar.bz2 tarball from the upstream website has the correct, updated release notes. I guess they fixed it manually because Git is still wrong and there's no 3.16.1+190314 on https://github.com/LimeSurvey/LimeSurvey/releases.

To avoid this problem, I've changed the code so it now reads the release notes from the upstream master branch, filtering out versions that are newer than the latest upstream tag (to avoid asking you to upgrade to a version that's not released yet).

#17 Updated by sajolida 6 months ago

  • Target version changed from Tails_3.13 to Tails_3.14

#18 Updated by sajolida 5 months ago

  • Status changed from In Progress to Resolved
  • Assignee deleted (sajolida)
  • QA Check deleted (Ready for QA)

Ack. It's been working (mostly) fine for some weeks! I've got some glitches but nothing too bad and, most importantly, I don't receive the GitHub notifications for LimeSurvey (though I receive them fine for Etcher).

#19 Updated by intrigeri 4 months ago

  • Target version changed from Tails_3.14 to Tails_3.13.2

#20 Updated by anonym 4 months ago

  • Target version changed from Tails_3.13.2 to Tails_3.14

#21 Updated by intrigeri 4 months ago

  • Target version changed from Tails_3.14 to Tails_3.13.2

Also available in: Atom PDF