Project

General

Profile

Bug #15391

Stop shipping python-qt4 that is no longer required

Added by intrigeri over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
-
Target version:
Start date:
03/09/2018
Due date:
% Done:

100%

Feature Branch:
bugfix/15391-stop-installing-useless-python-packages
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Electrum

Description

Potential regression since #15022: config/chroot_local-packageslists/tails-common.list says we install python-qt4 to Enable Electrum's Qt GUI. I believe it's wrong since electrum 3.0.6-1~bpo9+1 Recommends: python3-pyqt5 and has no dependency on Qt4.

We should check if we still need this package. If it's pulled by something else that needs it anyway, let's remove it from the list. If it's not pulled automatically but we need it, let's update the comment. If we don't need it, let's remove it from the list.


Related issues

Related to Tails - Feature #15022: Electrum package update to version 3.0.6 Resolved 12/07/2017
Blocks Tails - Feature #15139: Core work 2018Q2: Foundations Team Resolved 01/01/2018

Associated revisions

Revision da2910ba (diff)
Added by intrigeri over 1 year ago

Stop installing python-qt4 and python-trezor (refs: #15391).

Electrum 3.x instead uses python3-trezor (refs: #15390) and python3-qt5.

Revision 71aba57e
Added by bertagaz over 1 year ago

Merge remote-tracking branch 'origin/bugfix/15391-stop-installing-useless-python-packages' into stable

Fix-committed: #15391

History

#1 Updated by intrigeri over 1 year ago

  • Related to Feature #15022: Electrum package update to version 3.0.6 added

#2 Updated by intrigeri over 1 year ago

  • Subject changed from Check what to do with python-qt4 to Stop shipping python-qt4 that is no longer required
  • Type of work changed from Research to Code

FYI on Tails 3.6.1 nothing depends on that package and removing it frees 14.0 MB disk space (uncompressed). Deinstalling its no longer required dependencies frees another 24.5 MB disk space (uncompressed). And then Electrum still starts.

#3 Updated by intrigeri over 1 year ago

#4 Updated by intrigeri over 1 year ago

  • Assignee changed from anonym to intrigeri

#5 Updated by intrigeri over 1 year ago

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10
  • Feature Branch set to bugfix/15391-stop-installing-useless-python-packages

#6 Updated by intrigeri over 1 year ago

  • Assignee changed from intrigeri to anonym
  • % Done changed from 10 to 50
  • QA Check set to Ready for QA

FWIW this saves 8MB on the resulting ISO size. I've run the full test suite and only failures are:

  • "features/additional_software_packages.feature:8 # Scenario: Additional software packages are installed even without network": never seen it pass locally
  • "features/torified_gnupg.feature:31 # Scenario: Syncing OpenPGP keys using Seahorse should work and be done over Tor.": I've heard on XMPP about the keyserver having issues
  • "features/torified_gnupg.feature:43 # Scenario: Syncing OpenPGP keys using Seahorse started from the OpenPGP Applet should work and be done over Tor.": same as above

#7 Updated by bertagaz over 1 year ago

  • Assignee changed from anonym to bertagaz

Taking this over, for it to get in 3.7 in time.

#8 Updated by bertagaz over 1 year ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (bertagaz)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

bertagaz wrote:

Taking this over, for it to get in 3.7 in time.

Full test suite run passes so it's merged.

#9 Updated by bertagaz over 1 year ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF