Feature #14568: Additional Software Packages
Convert ASP to Python3 and follow PEP-8
As noted on #14570:
According to PEP 8, one-line docstrings should have the closing """ on the same line.
I agree, but fixing it here without doing it in all the file looks wierd, so I propose to forget about it for now, and do it later on when converting this file to python3. I plan to do that after all branches are merged and tests are written.
Fix python3 switch.
subprocess.Popen since Python 3.5 set STDIN and STDOUT output as binary,
unless its `universal_newlines` arg is set to True, in which case you
get text output that fits better with the way we parse this it later.
#3 Updated by alant almost 2 years ago
- Status changed from Confirmed to In Progress
- Assignee changed from alant to segfault
- QA Check set to Ready for QA
- Feature Branch set to feature/15198-asp-convert-to-python3-pep8
This branch is ready. Please note it is based on
feature/14572-automated-tests-for-ASP-offline-mode and should wait for it to be merged.
#12 Updated by anonym almost 2 years ago
- % Done changed from 0 to 50
- QA Check changed from Ready for QA to Pass
Looks good to me.
Same! Not merging due to the blockers.
The only remaining ugly code is the
f.closedin line 83, which has no effect.
Nice catch! I fixed it myself (b25e43c985eee068f3a8349ccb2e10a099ec10e7) and will keep this ticket until the blockers are merged or back on my plate.
#13 Updated by anonym almost 2 years ago
- Assignee changed from anonym to bertagaz
I [...] will keep this ticket until the blockers are merged or back on my plate.
Actually that doesn't make sense. The blockers are on bert's plate, so this one should be as well. But only the merge remains!
#15 Updated by bertagaz over 1 year ago
- Assignee deleted (