Project

General

Profile

Bug #15165

language_statistics.sh is broken by changes in refresh-translations

Added by intrigeri about 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Infrastructure
Target version:
Start date:
01/11/2018
Due date:
% Done:

100%

Feature Branch:
bugfix/15165-language-stats
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

See discussion on tails-dev@. Thread starts here: https://mailman.boum.org/pipermail/tails-dev/2017-December/011959.html


Related issues

Blocks Tails - Feature #13245: Core work 2018Q1: Foundations Team Resolved 06/29/2017

Associated revisions

Revision cb0d0ee3 (diff)
Added by intrigeri about 2 years ago

Add a --keep-tmp-pot option to refresh-translations and use it in language_statistics.sh (refs: #15165)

The current implementation of language_statistics.sh needs
the content of tmp/pot produced by refresh-translations,
but since commit d199d512d5cf64782a159176cf99412d332d40ac
refresh-translations always deletes it.

Revision 84faf0ee
Added by bertagaz almost 2 years ago

Merge remote-tracking branch 'origin/bugfix/15165-language-stats' into devel

Fix-committed: #15165

Revision 7582366d (diff)
Added by intrigeri almost 2 years ago

Add a --keep-tmp-pot option to refresh-translations and use it in language_statistics.sh (refs: #15165)

The current implementation of language_statistics.sh needs
the content of tmp/pot produced by refresh-translations,
but since commit d199d512d5cf64782a159176cf99412d332d40ac
refresh-translations always deletes it.

History

#1 Updated by intrigeri about 2 years ago

  • Assignee deleted (intrigeri)
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/15165-language-stats

#2 Updated by intrigeri about 2 years ago

#3 Updated by u about 2 years ago

  • Description updated (diff)

#4 Updated by u about 2 years ago

intrigeri has asked somebody if he'd like to handle the review of this over email. If not, this falls back to the RM's plate.

#5 Updated by anonym almost 2 years ago

  • Target version changed from Tails_3.5 to Tails_3.6

#6 Updated by intrigeri almost 2 years ago

  • Assignee set to bertagaz

kibi did not reply so let's put this explicitly on the RM's plate.

#7 Updated by bertagaz almost 2 years ago

  • Status changed from In Progress to 11
  • Assignee deleted (bertagaz)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

Smal patch that fixes the bug, so merged!

#8 Updated by sajolida almost 2 years ago

As this is meant to fix a problem in our contributor's documentation (building the monthly reports), shouldn't it be merged into master instead?

#9 Updated by intrigeri almost 2 years ago

  • Status changed from 11 to In Progress

#10 Updated by intrigeri almost 2 years ago

  • Status changed from In Progress to Resolved

As this is meant to fix a problem in our contributor's documentation (building the monthly reports), shouldn't it be merged into master instead?

Absolutely, sorry I did not make this explicit.

sajolida cherry-picked my commit on master (while it could have been merged, but whatever) so this is resolved :)

Also available in: Atom PDF