Project

General

Profile

Feature #15028

Feature #15678: Improve UX of saving downloaded files from Tor Browser

Rename "Tor Browser" shortcuts and folders

Added by huertanix over 1 year ago. Updated 12 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
03/27/2018
Due date:
% Done:

0%

QA Check:
Feature Branch:
wip/feature/15028-rename-tor-browser
Type of work:
User interface design
Blueprint:
Starter:
Affected tool:

Description

During a Tails training, users were asked to open Tor Browser, after already having a few Nautilus windows open. They clicked on the "Tor Browser" directory on the side panel in the open Nautilus window but were not sure what to do next since that just brought them to an empty directory.

Because 100% of these participants being trained had never used any Linux desktop before, they had no baseline expectations of how similar/dissimilar the Tails desktop would be to the Windows, OS X, iOS or Android interfaces they are also only somewhat used to.

The side panel shortcut "Tor Browser" should be renamed "Tor Downloads" and "Tor Downloads (Persistent)" for the persistent version. The default "Downloads" shortcut should be removed from the side panel, since it is neither used by the Tor Browser nor by the Unsafe Browser and only adds to the confusion.

See #15464 for pending questions and implementation leads.

Tor Browser Downloads.png View (77.8 KB) alant, 04/05/2019 10:50 AM

Tor Browser Downloads Menu.png View (90.6 KB) alant, 04/05/2019 10:50 AM

Tor Downloads.png View (78.5 KB) alant, 04/05/2019 10:51 AM


Related issues

Related to Tails - Bug #10790: Too many non-Tails folders on Nautilus sidebar In Progress 12/23/2015
Related to Tails - Feature #14544: Spend software developer time on smallish UX improvements In Progress 08/31/2018
Duplicated by Tails - Bug #15464: Rename "Tor Browser" into "Tor Downloads" Duplicate 03/27/2018

Associated revisions

Revision 7fcb0a6b (diff)
Added by alant about 2 months ago

Rename Tor Browser bookmarks

Will-fix: #15028

History

#1 Updated by sajolida over 1 year ago

  • Status changed from New to Confirmed
  • Assignee set to sajolida

Thanks huertanix for the very good feedback! At first sight I think it makes total sense. I'll assign the ticket to myself and put it on my UX plate. I'll get back to it later on after giving it a bit more thought...

#2 Updated by sajolida over 1 year ago

  • Blocks Feature #14761: Core work 2017Q4 → 2018Q1: User experience added

#3 Updated by u over 1 year ago

  • Type of work changed from Code to User interface design

#4 Updated by u over 1 year ago

  • Subject changed from Rename Downloads Shortcuts to Rename Downloads shortcut in Nautilus

#5 Updated by sajolida about 1 year ago

  • Blocks deleted (Feature #14761: Core work 2017Q4 → 2018Q1: User experience)

#6 Updated by sajolida about 1 year ago

  • Blocks Feature #15392: Core work 2018Q2 → 2018Q3: User experience added

#7 Updated by sajolida about 1 year ago

  • Related to Bug #10790: Too many non-Tails folders on Nautilus sidebar added

#8 Updated by sajolida about 1 year ago

During the user testing of Additional Software beta, P5 (who was looking for Mumble) opened Files and thought that the "Tor Browser" folder was referring to an application and not a folder. Like if the "Tor Browser" folder was where the Tor Browser application was saved.

The other preconfigured folders are all named as types of content ("Videos", "Music", etc.) and not as application ("Tor Browser").

This confirms and helps me understand better what huertanix reported.

#9 Updated by sajolida about 1 year ago

  • Related to Feature #14544: Spend software developer time on smallish UX improvements added

#10 Updated by sajolida about 1 year ago

  • Subject changed from Rename Downloads shortcut in Nautilus to Rename "Tor Browser" shortcuts and folders

#11 Updated by sajolida 12 months ago

  • Assignee deleted (sajolida)

I'll stop working on this more myself before I know who will write the code...

#12 Updated by sajolida 12 months ago

  • Blocks deleted (Feature #15392: Core work 2018Q2 → 2018Q3: User experience)

#13 Updated by sajolida 11 months ago

  • Parent task set to #15678

#14 Updated by sajolida 11 months ago

  • Tracker changed from Bug to Feature

#15 Updated by intrigeri 4 months ago

  • Description updated (diff)

#16 Updated by intrigeri 4 months ago

  • Duplicated by Bug #15464: Rename "Tor Browser" into "Tor Downloads" added

#17 Updated by sajolida 4 months ago

It might still be worth to rename "Tor Browser" into "Tor Downloads" even if we don't get rid of the "Downloads" folder yet:

  • In GNOME Files, Having "Tor Downloads" and "Downloads" might be less confusing than having (currently) "Tor Browser" and "Downloads".
  • When saving from Tor Browser, having "tor-browser", "Downloads" and "Tor Downloads" will probably be less confusing that having (currently) "tor-browser", "Downloads", and "Tor Browser".

#18 Updated by intrigeri 4 months ago

  • % Done changed from 100 to 0

#19 Updated by alant about 2 months ago

We can easily implement changing the bookmarks only without the folder names, beacuse of the persistent folder name (we could easily rename the non-persistent one, but it makes little sense).

I suggest "Tor Browser Downloads" and "Tor Browser Downloads (persistent)" for the bookmarks to have less confusion with actual folder names that would remain "Home / Tor Broweser".

Keeping the "Tor Downloads" wording, I think there is a confustion between the name on the top "Tor Browser" and the bookark name shown on the left "Tor Downloads":

Also changing the folder names would be quite some more work, but doable I think.

What do you think?

#20 Updated by alant about 2 months ago

  • Status changed from Confirmed to In Progress

#21 Updated by sajolida about 1 month ago

  • Assignee changed from sajolida to alant
  • QA Check set to Info Needed

I'm quite afraid of having inconsistent naming between the bookmark and the folder. I bet that for most users the bookmark and the folder itself are "the same thing", so having even slightly different names might lead them to believe that they are different places. The problem might affect newer users, with empty folders, more than users with some files in there already.

Could you elaborate on how harder it would be to rename the actual folder as well?

Is it about handling the renaming of the folder during a migration period or anything else?

To handle a migration, I would propose to display a confirmation dialog when starting Tails if a ~/Persistent/Tor Browser folder is present asking to rename it. Something like:

We are renaming the folder ~/Persistent/Tor Browser to ~/Persistent/Tor Downloads. Do you want to rename it now?
[Cancel] [Rename]

#22 Updated by alant 27 days ago

sajolida wrote:

I'm quite afraid of having inconsistent naming between the bookmark and the folder. I bet that for most users the bookmark and the folder itself are "the same thing", so having even slightly different names might lead them to believe that they are different places. The problem might affect newer users, with empty folders, more than users with some files in there already.

Ok.

Could you elaborate on how harder it would be to rename the actual folder as well?

It's not 2 lines on configuration anymore.

Is it about handling the renaming of the folder during a migration period or anything else?

Yes exactly.

To handle a migration, I would propose to display a confirmation dialog when starting Tails if a ~/Persistent/Tor Browser folder is present asking to rename it. Something like:

[...]

If you think it's better, the we should do that, but it may take longer.

#23 Updated by intrigeri 26 days ago

  • Assignee changed from alant to sajolida

Looks like Alan provided the requested info.

#24 Updated by sajolida 20 days ago

  • Assignee changed from sajolida to alant
  • QA Check deleted (Info Needed)

I want the bookmarks and the folders to have the same name, at least within a single Tails installation.

If it's less work than handling the migration as I proposed in #15028#note-21 another option could be to create ~/Persistent/Tor Downloads on all new Persistence and have the bookmarks be "Tor Downloads" and "Tor Downloads (persistent)" and otherwise keep the current bookmarks when the Persistence already has a ~/Persistent/Tor Browser folder.

But I guess that this would require moving the bookmark-naming logic at runtime and it might not be an option.

#25 Updated by sajolida 18 days ago

@huertanix: While discussing #14649, I came to wonder why shouldn't we call these folders "Downloads" and "Downloads (persistent)"?

@alant: Was removing the default "Downloads" folder part of your plan? What if we use it to store Tor Browser downloads?

#26 Updated by intrigeri 17 days ago

I want the bookmarks and the folders to have the same name, at least within a single Tails installation.

FTR we've already discussed this on #15464 (where I already asked whether it was OK to rename only the bookmarks) and we reached the same conclusion. I agree. FWIW, it's consistent with how GNOME handles localization of the standard XDG directories: e.g. when switching to French locales, GNOME will ask whether "Downloads" should be renamed to "Téléchargements", and if I accept, both the bookmark and the actual folder will be renamed, maintaining consistency between the folder name and the bookmark. Not to say we should localize these folders just yet :)

To handle a migration, I would propose to display a confirmation dialog when starting Tails if a ~/Persistent/Tor Browser folder is present asking to rename it.

Renaming a persistent folder in the GNOME session, while it's already potentially in use, involves some of the same technical challenges as #11529. I bet this would delay implementation and make the current shitty UX be around for longer. So I think we should rename the folder either while activating persistence in the Greeter (in live-persist), or in /usr/local/lib/create-tor-browser-directories that's run in the background during the login process.

Displaying a confirmation dialog there should be easy in itself, but then we increase complexity of related code forever: we need to support both user choices. I doubt it's worth the effort. I'd really prefer a unconditional migration, possibly with a notification once logged in to inform the user that the migration happened. This should be rather easy to implement (we already have code for this sort of things).

If it's less work than handling the migration as I proposed in #15028#note-21 another option could be to create ~/Persistent/Tor Downloads on all new Persistence and have the bookmarks be "Tor Downloads" and "Tor Downloads (persistent)" and otherwise keep the current bookmarks when the Persistence already has a ~/Persistent/Tor Browser folder.
But I guess that this would require moving the bookmark-naming logic at runtime and it might not be an option.

All these bookmarks are created at runtime already (/usr/local/lib/create-tor-browser-directories, started by /usr/lib/systemd/user/tails-create-tor-browser-directories.service). They don't persist.

huertanix: While discussing #14649, I came to wonder why shouldn't we call these folders "Downloads" and "Downloads (persistent)"?

I've replied on #15463#note-9.

Finally, wrt. naming of the bookmarks (<=> naming of the folders given we want them to be called the same as the bookmarks), beware of the length of the name: on Alan's screenshots, one can see that "Tor Downloads" fits in the GTK file chooser sidebar, while "Tor Browser Downloads" does not ("Tor Browser …" is displayed so we're back to square one).

#27 Updated by intrigeri 17 days ago

  • Feature Branch changed from feature/15028-rename-tor-browser to wip/feature/15028-rename-tor-browser

(It's now clear that the proposal in that branch won't be merged so let's not waste Jenkins cycles on it.)

@alant, are you up to working further on this soon? Else, I'll unassign you for now, so other developers know it's up for grabs.

#28 Updated by intrigeri 17 days ago

  • Assignee changed from alant to sajolida

Next steps:

  • Now that I've explained the technical constraints wrt. the migration process, state what's good enough from a UX PoV.
  • Make up our mind wrt. the folders name (see also #15463).

And then we can move on to the actual implementation! :)

#29 Updated by sajolida 13 days ago

Renaming a persistent folder in the GNOME session, while it's already potentially in use, involves some of the same technical challenges as #11529.

I didn't think about that! Then forget it.

So I think we should rename the folder either while activating persistence in the Greeter (in live-persist), or in /usr/local/lib/create-tor-browser-directories that's run in the background during the login process.

To be more specific, what I'm afraid here is for people who might have
stuff in ~/Persistent/Tor Browser to think that their files disappeared
if we don't tell them when starting Tails.

Another option might be to:

  • Rename the folder unconditionally.
  • Create a symlink from Persistent/Downloads to Persistent/Tor Browser
    if a folder was renamed.
  • Display a confirmation dialog when starting Tails and such a symlink
    is present.

It could be something like:

Your folder ~/Persistent/Tor Browser has been moved to
~/Persistent/Downloads.

You can use the shortcut in ~/Persistent/Tor Browser to find your files
easily. Once you get used to the new name, you can delete the shortcut.

[Cancel] [Delete Shortcut]

I'm guessing that this would create less complexity for you to manage in
the future while solving my problem. As always, we'll drop this
migration code whenever it becomes problematic in the future.

huertanix: While discussing #14649, I came to wonder why shouldn't we call these folders "Downloads" and "Downloads (persistent)"?

I've replied on #15463#note-9.

I'm all for "Downloads" then :)

Finally, wrt. naming of the bookmarks (<=> naming of the folders given we want them to be called the same as the bookmarks), beware of the length of the name: on Alan's screenshots, one can see that "Tor Downloads" fits in the GTK file chooser sidebar, while "Tor Browser Downloads" does not ("Tor Browser …" is displayed so we're back to square one).

"Downloads" is also the shorter option :)

#30 Updated by sajolida 13 days ago

  • Assignee changed from sajolida to alant

Now that I've explained the technical constraints wrt. the migration process, state what's good enough from a UX PoV.

@intrigeri: Would my new idea for the migration solve both your coding and my UX issues?

Make up our mind wrt. the folders name (see also #15463).

  • "Downloads" → "~/Downloads", for the amnesiac version
  • "Downloads (persistent)" → "~/Persistent/Downloads", for the persistent version

#31 Updated by huertanix 12 days ago

sajolida wrote:

huertanix: While discussing #14649, I came to wonder why shouldn't we call these folders "Downloads" and "Downloads (persistent)"?

I've replied on #15463#note-9.

I'm all for "Downloads" then :)

Finally, wrt. naming of the bookmarks (<=> naming of the folders given we want them to be called the same as the bookmarks), beware of the length of the name: on Alan's screenshots, one can see that "Tor Downloads" fits in the GTK file chooser sidebar, while "Tor Browser Downloads" does not ("Tor Browser …" is displayed so we're back to square one).

"Downloads" is also the shorter option :)

I'm also leaning towards Downloads, seems simpler and needs no explanation for someone coming into Tails from macOS or Windows. One question: Would the Unsafe Browser save downloads to the same directory and are there any security risks that this introduces that I'm not thinking of?

#32 Updated by sajolida 12 days ago

Would the Unsafe Browser save downloads to the same directory and are there any security risks that this introduces that I'm not thinking of?

I think that the Unsafe Browser is running as a different Unix user and
has no access whatsoever to the file system of the amnesia user.

Also available in: Atom PDF