Project

General

Profile

Feature #14556

Show a suspend to RAM button in the status menu

Added by segfault over 1 year ago. Updated 19 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
08/30/2017
Due date:
% Done:

0%

QA Check:
Pass
Feature Branch:
feature/14556-show-suspend-button
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

We might want to require setting up the screen locker (#5684) before suspending to RAM.


Related issues

Related to Tails - Feature #5684: Screen locker Resolved 12/03/2014
Related to Tails - Bug #11729: Emergency shutdown triggered after resuming from suspend Resolved 08/26/2016
Related to Tails - Bug #11052: Do not suspend when closing lid In Progress 05/03/2016
Related to Tails - Bug #15640: Suspend button shown when screen is locked Resolved 06/08/2018

Associated revisions

Revision f79d0cf6 (diff)
Added by segfault 2 months ago

Add suspend button to status-menu-helper (refs: #14556)

Revision 23c285a7 (diff)
Added by segfault 2 months ago

status-menu-helper: Remove unnecessary code (refs: #14556)

This code was from the original author of the suspend-button extension
and makes the restart and poweroff buttons visible when the menu
opens - but in fact the buttons are always visible, so this code has no
effect.

Revision a0cec878 (diff)
Added by segfault 2 months ago

Add suspend button to status-menu-helper (refs: #14556)

Revision 4440b19b (diff)
Added by segfault 2 months ago

status-menu-helper: Remove unnecessary code (refs: #14556)

  • Remove unused imports
  • Remove bind to 'open-state-changed'. This code was from the original author of
    the suspend-button extension and makes the restart and poweroff buttons
    visible when the menu opens - but in fact the buttons are always visible, so
    this code has no effect.

Revision 16581fb1 (diff)
Added by segfault 2 months ago

Add suspend button to status-menu-helper (refs: #14556)

Revision 5b8d8974 (diff)
Added by segfault 2 months ago

status-menu-helper: Remove unnecessary code (refs: #14556)

  • Remove unused imports
  • Remove bind to 'open-state-changed'. This code was from the original author of
    the suspend-button extension and makes the restart and poweroff buttons
    visible when the menu opens - but in fact the buttons are always visible, so
    this code has no effect.

Revision 7e129455 (diff)
Added by segfault 2 months ago

status-menu-helper: Clean up code (refs: #14556)

Revision 1616d490 (diff)
Added by segfault 2 months ago

status-menu-helper: Show poweroff and reboot buttons when locked (refs: #14556, #15640)

Revision 3af65b5f (diff)
Added by segfault 2 months ago

status-menu-helper: Refactor (refs: #14556)

Revision 6341fbef (diff)
Added by segfault about 2 months ago

status-menu-helper: Fix order of buttons (refs: #14556)

Revision 8f4bf911
Added by intrigeri about 2 months ago

Merge remote-tracking branch 'origin/feature/14556-show-suspend-button' into stable (Fix-committed: #11729, #14556)

History

#1 Updated by segfault over 1 year ago

#2 Updated by intrigeri over 1 year ago

  • Related to Bug #11729: Emergency shutdown triggered after resuming from suspend added

#3 Updated by intrigeri over 1 year ago

  • Related to Bug #11052: Do not suspend when closing lid added

#4 Updated by intrigeri over 1 year ago

  • Target version changed from 2018 to 2019

(as per updated roadmap)

#5 Updated by Gaff 12 months ago

Is suspending not a security risk? A suspended machine is at risk of being hacked - whereas a powered down machine is not. A user might assume his machine is powered down and thus safe from hacking.

(See also: #15640)

#6 Updated by intrigeri 12 months ago

  • Related to Bug #15640: Suspend button shown when screen is locked added

#7 Updated by segfault 2 months ago

  • Status changed from Confirmed to In Progress

#8 Updated by intrigeri 2 months ago

  • Target version deleted (2019)

(Looks like this one was missed when we updated Redmine after finalizing our 2019 roadmap.)

#9 Updated by segfault about 2 months ago

  • Feature Branch set to feature/14556-show-suspend-button

I changed the extension to display the suspend button, which I think we can safely do now since there seems to be a fix for #11729 (implemented on the same branch).

While at it, I also changed that now the poweroff and reboot buttons are still displayed when the screen is locked, for easier shutdown as a security feature, as suggested by sajolida in #15640#note-7.

#10 Updated by segfault about 2 months ago

  • Assignee deleted (segfault)
  • QA Check set to Ready for QA

#11 Updated by intrigeri about 2 months ago

  • Assignee set to intrigeri
  • Target version set to Tails_3.14

#12 Updated by intrigeri about 2 months ago

  • Assignee changed from intrigeri to segfault
  • QA Check changed from Ready for QA to Dev Needed

Great work! Only one comment: the order of the poweroff and restart buttons has been reversed. I could not find any explanation for this change in the Git log. Was this done on purpose? I have no strong opinion on this topic myself but I suggest getting sajolida's input (before/after screenshots would help).

Code review passes and it works fine during my tests.

@segfault, sending back to your plate for the above.

#13 Updated by segfault about 2 months ago

  • QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:

Great work! Only one comment: the order of the poweroff and restart buttons has been reversed. I could not find any explanation for this change in the Git log. Was this done on purpose?

No, that was not intended. I fixed it on the the branch.

#14 Updated by intrigeri about 2 months ago

  • Assignee changed from segfault to intrigeri

#15 Updated by intrigeri about 2 months ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

#16 Updated by intrigeri about 2 months ago

  • Assignee deleted (intrigeri)
  • % Done changed from 100 to 0
  • QA Check changed from Ready for QA to Pass

#17 Updated by sajolida about 1 month ago

@segfault: If I'm on a desktop and suspend to RAM, how do I wake up? Pressing any key? If I'm on a laptop and click the suspend to RAM option by mistake, how do I wake up?

#18 Updated by segfault about 1 month ago

sajolida wrote:

@segfault: If I'm on a desktop and suspend to RAM, how do I wake up? Pressing any key? If I'm on a laptop and click the suspend to RAM option by mistake, how do I wake up?

@sajolida: I guess it depends on the hardware/firmware. Pressing any key might work, pressing the power button should probably always work.

#19 Updated by sajolida 25 days ago

Pressing the power button, yes!

#20 Updated by intrigeri 21 days ago

  • Target version changed from Tails_3.14 to Tails_3.13.2

#21 Updated by anonym 19 days ago

  • Status changed from Fix committed to Resolved

#22 Updated by anonym 19 days ago

  • Target version changed from Tails_3.13.2 to Tails_3.14

#23 Updated by intrigeri 19 days ago

  • Target version changed from Tails_3.14 to Tails_3.13.2

Also available in: Atom PDF