Project

General

Profile

Bug #12369

Write a wrapper for KeePassX to open the old database if there is one but no new database

Added by sajolida over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
-
Target version:
Start date:
03/18/2017
Due date:
% Done:

100%

Feature Branch:
bugfix/12260-open-keepassx-database-by-default
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Password Manager

Related issues

Blocked by Tails - Bug #12260: Have KeePassX open ~/Persistent/keepassx.kbdx by default Resolved 02/24/2017
Blocks Tails - Bug #12368: Design UX for migrating databases to KeePassX 2 Resolved 03/18/2017
Blocks Tails - Bug #12375: If a custom-named KeePassX database is found in the Persistent folder, propose renaming it Resolved 03/19/2017

Associated revisions

Revision 38ba45e1 (diff)
Added by bertagaz over 2 years ago

Start keepassx even if not doing a migration.

And simplify the conditions, it doesn't matter if Persistent folder is
mounted or not.

Refs: #12369

Revision 5cb3f5ef (diff)
Added by bertagaz over 2 years ago

Move newly migrated keepassx database to the right place.

It's saved with a different filename by default, and not in the right
folder. This should solve this issue.

Refs: #12369

Revision 2b21e99c (diff)
Added by bertagaz over 2 years ago

Save and restore keepassx settings around migrating the database.

Otherwise, in the same Tails session, if the user restarts keepassx,
she will be asked to open the old database first because of remainings
in the conf history. Let's clean that up.

Refs: #12369

Revision a784c081 (diff)
Added by intrigeri over 2 years ago

KeePassX wrapper: add "set -u" (refs: #12369).

Revision 9430451b (diff)
Added by intrigeri over 2 years ago

KeePassX wrapper: DRY! (refs: #12369)

Revision b0446015 (diff)
Added by intrigeri over 2 years ago

KeePassX wrapper: fix typo and wrap long line (refs: #12369).

Revision b9cc1e53 (diff)
Added by intrigeri over 2 years ago

KeePassX wrapper: forward the command-line args we got when we can (refs: #12369).

The .desktop file has "Exec=keepassx %f".

Revision a004a485 (diff)
Added by intrigeri over 2 years ago

KeePassX wrapper: add safeguard (refs: #12369).

Revision 2b9132b3 (diff)
Added by intrigeri over 2 years ago

KeePassX wrapper: refactor (refs: #12369).

Let's not even go through the migration code if there's already a new-style DB.

Revision a245f2d6 (diff)
Added by intrigeri over 2 years ago

KeePassX wrapper: avoid importing the v1 DB more than once (refs: #12369).

Without this change, after importing one's v1 DB, one would be prompted to
re-import it every time they start KeePassX again if they saved their new DB
under a name that's neither "New database.kdbx" nor "keepassx.kdbx".

Revision e456ecd5 (diff)
Added by intrigeri over 2 years ago

KeePassX wrapper: clarify branching logics (refs: #12369).

Revision 50139e9f (diff)
Added by intrigeri over 2 years ago

KeePassX wrapper: avoid symlink attacks (refs: #12369).

Revision 2e7b6d81 (diff)
Added by intrigeri over 2 years ago

KeePassX wrapper: document the (shared) purpose of two somewhat obscure lines of code (refs: #12369).

Revision 389e0375 (diff)
Added by intrigeri over 2 years ago

KeePassX wrapper: improve comment (refs: #12369).

Revision 8b1ac970 (diff)
Added by intrigeri over 2 years ago

KeePassX wrapper: DRY (refs: #12369).

Revision f72faf36
Added by intrigeri over 2 years ago

Merge branch 'bugfix/12260-open-keepassx-database-by-default' into feature/stretch

Closes: #12260, #12369

Revision 8db5a89d (diff)
Added by intrigeri over 2 years ago

KeePassX wrapper: avoid messing with the user's configuration (refs: #12369).

History

#1 Updated by sajolida over 2 years ago

  • Blocks Feature #10956: Document how to migrate existing KeePassX database added

#2 Updated by intrigeri over 2 years ago

  • Subject changed from Write a wrapper for KeePassX to open the old database if there is one to Write a wrapper for KeePassX to open the old database if there is one but no new database
  • Priority changed from Normal to Elevated

#3 Updated by bertagaz over 2 years ago

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 20
  • Feature Branch set to bugfix/12260-open-keepassx-database-by-default

Wrote and pushed it in the branch where spriver pushed something for #12260. Now is time for testing.

#4 Updated by bertagaz over 2 years ago

  • % Done changed from 20 to 50

Now the wrapper also rename the upgraded database to the right filename.

#5 Updated by bertagaz over 2 years ago

  • Assignee changed from bertagaz to intrigeri
  • QA Check set to Ready for QA

Branch is now (as of 2b21e99cbfbdeb7f6ec2a2a3f05f702d31e0ed63) confirmed to work as first planed.

This is good enough to set this ticket RfQA and for the branch to be merged.

Next step will require another ticket to track its progress. We decided to propose to move any uniq .kdbx file to the canonical name we support, and not care about people who store their database(s) outside this supported path.

#6 Updated by intrigeri over 2 years ago

  • Blocked by Bug #12260: Have KeePassX open ~/Persistent/keepassx.kbdx by default added

#7 Updated by intrigeri over 2 years ago

  • Blocks Bug #12368: Design UX for migrating databases to KeePassX 2 added

#8 Updated by intrigeri over 2 years ago

  • Blocks deleted (Feature #10956: Document how to migrate existing KeePassX database)

#9 Updated by bertagaz over 2 years ago

  • Related to Bug #12375: If a custom-named KeePassX database is found in the Persistent folder, propose renaming it added

#10 Updated by intrigeri over 2 years ago

  • Related to Feature #10956: Document how to migrate existing KeePassX database added

#11 Updated by bertagaz over 2 years ago

bertagaz wrote:

Next step will require another ticket to track its progress. We decided to propose to move any uniq .kdbx file to the canonical name we support, and not care about people who store their database(s) outside this supported path.

Done: #12375

#12 Updated by intrigeri over 2 years ago

  • Related to deleted (Bug #12375: If a custom-named KeePassX database is found in the Persistent folder, propose renaming it)

#13 Updated by intrigeri over 2 years ago

  • Blocks Bug #12375: If a custom-named KeePassX database is found in the Persistent folder, propose renaming it added

#14 Updated by intrigeri over 2 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100

#15 Updated by intrigeri over 2 years ago

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#16 Updated by intrigeri over 2 years ago

  • Related to deleted (Feature #10956: Document how to migrate existing KeePassX database)

#17 Updated by sajolida over 2 years ago

  • Affected tool set to Password Manager

Also available in: Atom PDF