Project

General

Profile

Bug #12359

Feature #5464: Revamp Greeter interface

Feature #8230: Greeter revamp: Phase 1

Language selector in the revamped Greeter always picks top entry when Enter is pressed

Added by anonym over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
-
Target version:
Start date:
03/17/2017
Due date:
% Done:

100%

Feature Branch:
bugfix/12359-fix-enter-empty-searchentry
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Greeter

Description

This might make sense most of the time, but not when the search field is empty. Here's an example:

  • Boot Tails and stop at the Greeter. Notice that "Language" is focused.
  • If I press Enter, it will open the Language selector pop-up.
  • If I press Enter again (i.e. no text was ever typed into the search field), the top entry is applied, which happens to be "Afar - Djibouti". I suspect this is not what users will expect.

I fear this will happen a lot to users that are used to just pressing Enter at the Greeter to start Tails with the defaults.

A simple fix would be that, in the Language selector pop-up, if the search field is empty, pressing Enter simply closes pop-up without changing the language settings.

Note: this bug probably affects all other "selectors pop-ups" as well, e.g. Keyboard layout and Formats, and should be fixed there too.

Here are two slightly different behavior related to illustrate this issue. They are probably both related but we should make sure that the fix for the first one should also fix the second one.

1.

  • Start Tails.
  • English is selected.
  • Open the popup: English is still selected (expected).
  • Press Enter: Afar - Djibouti is selected. It should instead stick to English.

2.

  • Open the popup. Type "ara" and press Enter.
  • Aragonese is selected (expected).
  • Open the popup again: "ara" is still typed in and Aragonese is selected (expected).
  • Press Enter: Aragonese is still selected (expected).
  • Open the popup again.
  • Press Backspace: "ara" gets deleted (expected) but Aragonese is still selected (expected).
  • Press Enter: Afar - Djibouti is selected. It should instead stick to Aragonese.

History

#1 Updated by intrigeri over 2 years ago

  • Priority changed from Normal to Elevated

We already one other bug report about this, so bumping priority.

#2 Updated by alant over 2 years ago

  • Parent task set to #8230

#3 Updated by sajolida over 2 years ago

  • Description updated (diff)

#4 Updated by alant over 2 years ago

  • Status changed from Confirmed to In Progress
  • Assignee changed from alant to anonym
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/12359-fix-enter-empty-searchentry

#5 Updated by intrigeri over 2 years ago

  • % Done changed from 0 to 50

anonym, I'd like to see this fix in 3.0~beta4 (April 18, same day as 2.12). Any chance you review this in time, e.g. during the 2.12 freeze? If not, please reassign to me.

#6 Updated by anonym over 2 years ago

  • Status changed from In Progress to 11
  • Assignee deleted (anonym)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

Both issues in the description are fixed => merged!

#7 Updated by intrigeri over 2 years ago

  • Status changed from 11 to Resolved

Also available in: Atom PDF