Project

General

Profile

Feature #12186

Add keyboard shortcuts to the (revamped) Greeter

Added by anonym almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
Accessibility
Target version:
Start date:
01/28/2017
Due date:
% Done:

100%

Feature Branch:
greeter:feature/12186-keyboard-shortcuts
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Greeter

Description

While I find the revamped Greeter absolutely awesome, I find it more cumbersome since keyboard navigation is more complex.

Main window:
  • Alt+L: Language
  • Alt+K: Keyboard layout
  • Alt+F: Formats
  • Alt+P: Persistence
  • Alt+R: Read-only persistence
  • Alt-A: Additional Settings window
  • Ctrl+Enter and/or Alt+S: Start Tails

For "Additional Settings" we could have a shortcut each (which opens that option's window):

  • Ctrl+Shift+A: Administrator password
  • Ctrl+Shift+M: MAC spoofing
  • Ctrl+Shift+N: Network settings

Related issues

Related to Tails - Bug #12509: The Greeter should have initial keyboard focus on the default action. Resolved 05/05/2017

History

#1 Updated by intrigeri almost 3 years ago

  • Related to Bug #12063: Keyboard-only usability regression for intrigeri's development use case added

#2 Updated by intrigeri almost 3 years ago

  • Assignee set to anonym
  • QA Check set to Info Needed

Could you please check if the changes I've proposed on #12063 would be enough to address the problems you're experiencing?

#3 Updated by anonym almost 3 years ago

  • Assignee changed from anonym to intrigeri

I guess it'd be good enough for the regressions in my development use case. :)

I still think all controls exposed on the main page should have accessors (users of non-default locales will be very thankful!), and I think the Ctrl+Shift (or whatever) shortcuts for each option will be appreciated by power users and users in need of better accessibility support alike.

#4 Updated by intrigeri almost 3 years ago

  • QA Check changed from Info Needed to Dev Needed

I guess it'd be good enough for the regressions in my development use case. :)

Good.

I still think all controls exposed on the main page should have accessors (users of non-default locales will be very thankful!), and I think the Ctrl+Shift (or whatever) shortcuts for each option will be appreciated by power users and users in need of better accessibility support alike.

ACK

#5 Updated by intrigeri almost 3 years ago

  • Assignee changed from intrigeri to alant

Alan, what do you think?

#6 Updated by alant almost 3 years ago

Looks great, I can work on that and have it ready for the end of the march sprint at latest. Would it work ?

#7 Updated by intrigeri almost 3 years ago

Looks great, I can work on that and have it ready for the end of the march sprint at latest. Would it work ?

Sure!

#8 Updated by alant almost 3 years ago

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 30
  • Feature Branch set to greeter:feature/1218feature/12186-keyboard-shortcuts6-keyboard-shortcuts

#9 Updated by alant almost 3 years ago

  • Feature Branch changed from greeter:feature/1218feature/12186-keyboard-shortcuts6-keyboard-shortcuts to feature/12186-keyboard-shortcuts

#10 Updated by alant almost 3 years ago

  • Assignee changed from alant to intrigeri
  • % Done changed from 30 to 60
  • QA Check changed from Dev Needed to Ready for QA
  • Feature Branch changed from feature/12186-keyboard-shortcuts to greeter:feature/12186-keyboard-shortcuts

The proposed keyboard shortcuts are implemented in feature/12186-keyboard-shortcuts. The mnemonics are discoverable, but the <Control>+<Shift>+<Key> accelerators are not. We may want to add a GtkShortcutWindow (https://developer.gnome.org/gtk3/stable/GtkShortcutsWindow.html) for that, but that would require some design.

#11 Updated by anonym almost 3 years ago

alant wrote:

The proposed keyboard shortcuts are implemented in feature/12186-keyboard-shortcuts.

Woo! I tried it, and I love it!

The mnemonics are discoverable, but the <Control>+<Shift>+<Key> accelerators are not. We may want to add a GtkShortcutWindow (https://developer.gnome.org/gtk3/stable/GtkShortcutsWindow.html) for that, but that would require some design.

A simpler solution that's also discoverable is to mention the shortcut in each option's window.

#12 Updated by anonym almost 3 years ago

This introduces a regression: when I open the Administration Password window the first time and type the password, pressing Enter won't change focus to the second password field like it used to, but it closes the window, resulting in the option being added, but disabled.

#13 Updated by intrigeri almost 3 years ago

  • Assignee changed from intrigeri to alant
  • QA Check changed from Ready for QA to Dev Needed

#14 Updated by alant almost 3 years ago

  • Assignee changed from alant to intrigeri
  • % Done changed from 60 to 80
  • QA Check changed from Dev Needed to Ready for QA

anonym wrote:

This introduces a regression: when I open the Administration Password window the first time and type the password, pressing Enter won't change focus to the second password field like it used to, but it closes the window, resulting in the option being added, but disabled.

This should be fixed.

#15 Updated by intrigeri over 2 years ago

  • Assignee changed from intrigeri to alant
  • QA Check changed from Ready for QA to Dev Needed

conflicts with current feature/stretch

#16 Updated by intrigeri over 2 years ago

  • Priority changed from Normal to Elevated

#17 Updated by alant over 2 years ago

  • Assignee changed from alant to intrigeri
  • QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:

conflicts with current feature/stretch

Fixed.

#18 Updated by intrigeri over 2 years ago

  • QA Check changed from Ready for QA to Pass

Code review passes! Merged locally, will test and put a new release out once I've reviewed (and hopefully merged) the 2 other Greeter branches that are pending review. Then I'll evaluate the new behaviour based on my usability report (#12063).

#19 Updated by intrigeri over 2 years ago

Uploaded, will be included in next builds of feature/stretch.

#20 Updated by intrigeri over 2 years ago

  • Status changed from In Progress to Resolved
  • Assignee deleted (intrigeri)
  • % Done changed from 80 to 100

#21 Updated by sajolida over 2 years ago

  • Related to Bug #12509: The Greeter should have initial keyboard focus on the default action. added

#22 Updated by intrigeri over 2 years ago

  • Related to deleted (Bug #12063: Keyboard-only usability regression for intrigeri's development use case)

Also available in: Atom PDF