Project

General

Profile

Bug #12129

Test suite's --view broken on sid: xtightvncviewer was replaced

Added by intrigeri almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Test suite
Target version:
Start date:
01/11/2017
Due date:
% Done:

100%

Feature Branch:
test/12129-tigervnc-viewer
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

It should use xtigervncviewer instead of xtightvncviewer, that's now a transitional package that ships no binary.

Associated revisions

Revision 53f485b8 (diff)
Added by anonym almost 3 years ago

Support both xtigervncviewer and xtightvncviewer for --view.

xtightvncviewer is a transitional package in Sid, which depends on
tigervnc-viewer (which ships xtigervncviewer), so by keeping the dep
and supporting both binaries, --view will work on both Sid and Jessie.

Will-fix: #12129

Revision 0cf20f72 (diff)
Added by anonym almost 3 years ago

Deprecate xtightvncviewer in favor of tigervnc-viewer.

xtightvncviewer is a transitional package depending on tigervnc-viewer
in Debian Stretch.

Refs: #12129

Revision a95736d7
Added by intrigeri almost 3 years ago

Merge remote-tracking branch 'origin/test/12129-tigervnc-viewer' into stable (Fix-committed: #12129).

History

#1 Updated by anonym almost 3 years ago

tigervnc-viewer (which is the package I presume you mean) is not available in Jessie (nor jessie-backports) and our dependency checking does not support "or", so we have to be a bit more clever than simply switching dependency. I propose we

  • in stable (etc) keep the dependency on xtightvncviewer but also support the tigervnc-viewer binary, if available.
  • in feature/stretch (after merging the above into it) drop everything related to xtightvncviewer and just depend on tigervnc-viewer.

That should work, right? And once Tails 3.0 is released, all should be good without further action, so we can just forget about this.

#2 Updated by anonym almost 3 years ago

anonym wrote:

  • in feature/stretch (after merging the above into it) drop everything related to xtightvncviewer and just depend on tigervnc-viewer.

Scratch this part -- we still want to support testing the feature/stretch branch on Jessie! So...

And once Tails 3.0 is released, all should be good without further action, so we can just forget about this.

... instead we file a ticket to do the above bullet's action when we merge feature/stretch.

#3 Updated by intrigeri almost 3 years ago

And once Tails 3.0 is released, all should be good without further action, so we can just forget about this.

... instead we file a ticket to do the above bullet's action when we merge feature/stretch.

This relies on the fact that we'll stop supporting Jessie for running the test suite at exactly the same time as the feature/stretch merge. I don't think we've ever done this, as it's not practical for various reasons (e.g. it forces us to upgrade isotesters at exactly that time as well, in lockstep, and I doubt I'll be able to do that while RM'ing 3.0).

So perhaps instead make this part of #11739 (or even revert it immediately in the topic branch for that ticket, creating it if needed)?

#4 Updated by anonym almost 3 years ago

  • Status changed from Confirmed to In Progress

#5 Updated by anonym almost 3 years ago

  • Assignee changed from anonym to intrigeri
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to test/12129-tigervnc-viewer

Thanks for your input! Please review'n'merge into stable.

I pushed a branch for #11739 dealing with the follow up vs xtightvncviewer like you suggested.

#6 Updated by intrigeri almost 3 years ago

  • Subject changed from Test suite's --view broken on sid: to Test suite's --view broken on sid: xtightvncviewer was replaced
  • % Done changed from 50 to 60

Code review passes.

#7 Updated by intrigeri almost 3 years ago

  • Status changed from In Progress to 11
  • % Done changed from 60 to 100

#8 Updated by intrigeri almost 3 years ago

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#9 Updated by anonym almost 3 years ago

  • Status changed from 11 to Resolved

#10 Updated by intrigeri almost 3 years ago

FTR this transition was reverted (https://bugs.debian.org/852855) in sid, so if we have issues with tigervnc we could revert these changes on our side.

Also available in: Atom PDF