Project

General

Profile

Feature #12072

Don't give *Setting objects full access to the greeter object

Added by alant almost 3 years ago. Updated 9 months ago.

Status:
Confirmed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
12/23/2016
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Greeter

Description

tailsgreeter/gui.py AdminSetting.apply(): the action at a distance on next line is scary; better return the admin password (or False if the check fails), and let the caller modify its own state... or do some slightly less scary action at a distance? Same comment wrt. the disable method, and more generally it feels wrong that each *Setting objects gets a greeter attribute they can mess with as they want.

The ultimate goal should be to have all controller logic in GreeterApplication, which could be moved to tailsgreeter.

History

#1 Updated by intrigeri almost 3 years ago

  • Subject changed from Don't pass greeter attribute to each setting to Don't give *Setting objects full access to the greeter object

#2 Updated by u over 2 years ago

  • Assignee set to alant

Assigning to the reporter.

#3 Updated by sajolida 9 months ago

  • Parent task deleted (#11643)

Also available in: Atom PDF