Project

General

Profile

Bug #12004

Update power button handling for Stretch

Added by sajolida almost 3 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Hardware support
Target version:
Start date:
11/28/2016
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

I'm in 2.7 on a ThinkPad X201 and pressing the power button for 1 sec doesn't do anything, neither trigger emergency shutdown, neither display a menu as I think it used to do on Tails < 2.0.

But sycamoreone says it's working for him in 2.0 in #7334#note-10.

So this probably happens on some computer but not on others.

My personal take is that I'm not sure it's worth keeping this feature if it's sometimes broken on some machines or complicated to fix.

Associated revisions

Revision 3b1c0f35 (diff)
Added by intrigeri almost 3 years ago

Don't try to bind the Power button to the shutdown action (refs: #12004).

This is not supported in GNOME anymore:

… and it doesn't work on all hardware.

Revision d687dc65 (diff)
Added by intrigeri almost 3 years ago

Release notes: document more changes in button handling.

refs: #12004

History

#1 Updated by spriver almost 3 years ago

This seems to be hardware related, at least pressing the power button on my Dell E6410 will cause an immediate emergency shutdown.

#2 Updated by intrigeri almost 3 years ago

  • Subject changed from Pressing the power button does not immediately trigger emergency shutdown to Pressing the power button does not immediately trigger emergency shutdown on some machines

#3 Updated by intrigeri almost 3 years ago

  • Status changed from New to In Progress
  • Assignee set to sajolida
  • % Done changed from 0 to 10
  • QA Check set to Info Needed

spriver wrote:

This seems to be hardware related,

Indeed. I bet it works on most machines. At least it works on the MacBook Pro I have here too.

I've verified that our settings for this are correct on 2.7.1. It's a different matter for 3.0 though, as GNOME doesn't offer the possibility to configure the power button to trigger a shutdown (except in VMs, where it's the default action) anymore:

The available actions are: nothing, suspend, hibernate.

IMO we should set it to "nothing" right now, and later to "suspend" once #11729 (which blocks #11395, and in turn #11052) is done. Thoughts?

#4 Updated by sajolida almost 3 years ago

  • Assignee changed from sajolida to intrigeri

I agree with "nothing" right now. I'm not sure about "suspend" in the future and would instead stick to the GNOME default since we'll already have graphical way to suspend with #11395.

Shall we use this ticket to implement '"nothing" right now'?

#5 Updated by intrigeri almost 3 years ago

  • Assignee changed from intrigeri to sajolida

I'm not sure about "suspend" in the future and would instead stick to the GNOME default since we'll already have graphical way to suspend with #11395.

I think that "suspend" is the default in GNOME on Stretch.

Shall we use this ticket to implement '"nothing" right now'?

The way I see it, we currently have something that's useful and works for most people. Due to changes in GNOME we'll have to drop it in Tails 3.0, and use either "nothing" or the new GNOME defaults instead. But I see no strong reason to remove this piece of functionality right now (we have tons of other useful functionality that doesn't work for 100% of our users, and we rarely use this as an argument to drop it). But I'm happy to listen and understand why you want to switch to "nothing" in 2.x :)

#6 Updated by sajolida almost 3 years ago

  • Assignee changed from sajolida to intrigeri

You said IMO we should set it to "nothing" right now in #12004#note-3 so I was merely agreeing with you. I suggested this originally in the description of this ticket with I'm not sure it's worth keeping this feature.

Now, regarding when exactly to implement that I don't really care if it's in 2.x or 3.x and it's definitely not high prio. But I think we should aim at sticking to the GNOME default at some point.

But keep in mind that having this feature work on some computers and not on others can be a bit sensitive. We have implemented as one option for emergency shutdown and Tails is live and can be used on different laptops. So if one day I have to use a different laptop and am trained to do emergency shutdown this way and it doesn't work on this particular laptop, then I might get confused, panic, etc.

#7 Updated by intrigeri almost 3 years ago

  • Assignee changed from intrigeri to sajolida

You said IMO we should set it to "nothing" right now in #12004#note-3 so I was merely agreeing with you.

I meant "on the feature/stretch branch". Sorry I've been super unclear!

Now, regarding when exactly to implement that I don't really care if it's in 2.x or 3.x and it's definitely not high prio. But I think we should aim at sticking to the GNOME default at some point.

ACK. Please just decide if we switch to "nothing" in 2.x or 3.x and I'll gladly implement it :)

But keep in mind that having this feature work on some computers and not on others can be a bit sensitive. We have implemented as one option for emergency shutdown and Tails is live and can be used on different laptops. So if one day I have to use a different laptop and am trained to do emergency shutdown this way and it doesn't work on this particular laptop, then I might get confused, panic, etc.

Sure. Sadly, that's also true for some of the other ways to trigger a shutdown (e.g. it doesn't work with some SD-card readers).

#8 Updated by sajolida almost 3 years ago

I meant "on the feature/stretch branch". Sorry I've been super unclear!

Ah, ok!

ACK. Please just decide if we switch to "nothing" in 2.x or 3.x and I'll gladly implement it :)

If it's the same amount of work to do it in 2.x and 3.x (eg. no
migration work for 3.x), then I'd say do it on 2.x. If it's more work to
do it on 2.x and port it to 3.x, then I'd say do it on 3.x.

#9 Updated by sajolida almost 3 years ago

  • Assignee changed from sajolida to intrigeri
  • QA Check changed from Info Needed to Dev Needed

#10 Updated by intrigeri almost 3 years ago

  • Target version set to Tails_3.0

ACK. Please just decide if we switch to "nothing" in 2.x or 3.x and I'll gladly implement it :)

If it's the same amount of work to do it in 2.x and 3.x (eg. no migration work for 3.x), then I'd say do it on 2.x. If it's more work to do it on 2.x and port it to 3.x, then I'd say do it on 3.x.

Thanks!

The prefs name have changed so doing it on 2.x would imply a (little, but still) additional work ⇒ I'll do that for 3.0.
We'll need a note for it in the release notes. I'm considering adding a news/version_3.0 on feature/stretch, so that at least I can add notes there for you to consider later.

#11 Updated by sajolida almost 3 years ago

The prefs name have changed so doing it on 2.x would imply a (little, but still) additional work ⇒ I'll do that for 3.0.
We'll need a note for it in the release notes. I'm considering adding a news/version_3.0 on feature/stretch, so that at least I can add notes there for you to consider later.

Done in 69291c8. I understand that this change wouldn't be in the
Changelog because it's silent from a code point of view. Otherwise, I'll
already have plenty of hints in the Changelog for writing the release notes.

#12 Updated by intrigeri almost 3 years ago

Done in 69291c8.

:)

I understand that this change wouldn't be in the Changelog because it's silent from a code point of view.

We do document such stuff in the changelog (see the "Adjustments for Debian 8 (Jessie) with no or very little user-visible impact" section in the changelog entry for 2.0.)

#13 Updated by intrigeri almost 3 years ago

  • Subject changed from Pressing the power button does not immediately trigger emergency shutdown on some machines to Update power button handling for Stretch
  • % Done changed from 10 to 50
  • QA Check changed from Dev Needed to Ready for QA
  • Type of work changed from Research to Code

Done in Git.

#14 Updated by intrigeri almost 3 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

Works.

#15 Updated by Anonymous over 1 year ago

This doesn't work anymore for some time now

#16 Updated by intrigeri over 1 year ago

This doesn't work anymore for some time now

That is? What are you doing, what do you expect to happen, and what happens instead?

Also available in: Atom PDF