Project

General

Profile

Feature #11936

Bug #8309: Remove the topIcons GNOME Shell extension

Bug #8310: Convert OpenPGP Applet into a proper GNOME Shell extension

OpenPGP applet GNOME Shell extension: dynamically update the icon & menu depending on the content of the clipboard

Added by intrigeri about 3 years ago. Updated 9 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
11/16/2016
Due date:
% Done:

50%

Feature Branch:
alan/openpgp-applet:feature/8310-gnome-shell
Type of work:
Code
Blueprint:
Starter:
Affected tool:
OpenPGP Applet

testDBusService.py View (1.42 KB) alant, 11/17/2016 12:38 AM


Related issues

Blocked by Tails - Feature #11934: Have org.Tails.OpenPGPApplet send signals when the type of what's in the clipboard changes Confirmed 11/16/2016

History

#1 Updated by intrigeri about 3 years ago

  • Blocked by Feature #11934: Have org.Tails.OpenPGPApplet send signals when the type of what's in the clipboard changes added

#2 Updated by alant about 3 years ago

  • File testDBusService.py View added
  • Assignee changed from alant to intrigeri
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA

There is a working implementation in alan/openpgp-applet:feature/8310-gnome-shell. It is waiting for the service to send the ClipboardContentChanged signal with a single boolean is_encrypted parameter.

Find attached a dummy service for testing purpose. To send ClipboardContentChanged (True):

dbus-send --print-reply --type=method_call --dest=org.Tails.OpenPGPApplet /org/Tails/OpenPGPApplet org.Tails.OpenPGPApplet.EmitTrue

To send ClipboardContentChanged (False):
dbus-send --print-reply --type=method_call --dest=org.Tails.OpenPGPApplet /org/Tails/OpenPGPApplet org.Tails.OpenPGPApplet.EmitFalse

#3 Updated by intrigeri about 3 years ago

  • Status changed from Confirmed to In Progress

#4 Updated by intrigeri almost 3 years ago

  • Assignee changed from intrigeri to alant
  • QA Check changed from Ready for QA to Dev Needed

alant wrote:

There is a working implementation in alan/openpgp-applet:feature/8310-gnome-shell. It is waiting for the service to send the ClipboardContentChanged signal with a single boolean is_encrypted parameter.

Great, thanks! Sadly, this interface is a bit too simplistic, as there are more than two types of content in the clipboard (and corresponding icon indicators): we have none (empty clipboard), encrypted, signed, and (plain)text. The package also ships an icon for when a key is detected in the clipboard, but AFAIK it's not used yet. So I suggest we pass a string argument to the signal, and let's use the same values that are already used elsewhere in the code: "message" (== encrypted), "none", "signed", and "text" (plaintext).

Sorry I didn't specify this better initially!

#5 Updated by intrigeri almost 3 years ago

  • Blocked by deleted (Feature #11934: Have org.Tails.OpenPGPApplet send signals when the type of what's in the clipboard changes)

#6 Updated by alant almost 3 years ago

  • Assignee changed from alant to intrigeri

Great, thanks! Sadly, this interface is a bit too simplistic, as there are more than two types of content in the clipboard (and corresponding icon indicators): we have none (empty clipboard), encrypted, signed, and (plain)text. The package also ships an icon for when a key is detected in the clipboard, but AFAIK it's not used yet. So I suggest we pass a string argument to the signal, and let's use the same values that are already used elsewhere in the code: "message" (== encrypted), "none", "signed", and "text" (plaintext).

Looks good, tell me when it is implemented on your side.

#7 Updated by intrigeri almost 3 years ago

  • Blocked by Feature #11934: Have org.Tails.OpenPGPApplet send signals when the type of what's in the clipboard changes added

#8 Updated by intrigeri almost 3 years ago

  • Assignee changed from intrigeri to alant
  • QA Check deleted (Dev Needed)

alant wrote:

Looks good, tell me when it is implemented on your side.

Sure. Re-added the blocking dependency then.

#9 Updated by intrigeri over 2 years ago

  • Target version changed from Tails_3.0 to Tails_3.2

#10 Updated by intrigeri about 2 years ago

  • Target version deleted (Tails_3.2)

#11 Updated by nodens almost 2 years ago

Not duplicating this issue upstream, since the work referenced here doesn't exist on upstream repository at https://salsa.debian.org/openpgp-applet-team/openpgp-applet/.
Feel free to create an issue and create a branch or refer to the current work somehow there ;)

#12 Updated by intrigeri 9 months ago

  • Assignee deleted (alant)

Also available in: Atom PDF