Project

General

Profile

Bug #11457

Bug #10288: Fix newly identified issues to make our test suite more robust and faster

"I close the Unsafe Browser" step is fragile

Added by intrigeri over 3 years ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Start date:
05/22/2016
Due date:
% Done:

100%

Feature Branch:
https://salsa.debian.org/tails-team/tails/merge_requests/33
Type of work:
Code
Blueprint:
Starter:
Affected tool:
Unsafe Browser

Description

Video attached. I suspect that ctrl-q doesn't reach the right window, e.g. because it's emitted immediately after we close the notification area, and before GNOME Shell has had time to focus the browser's window. Perhaps we should explicitly focus it first?

Associated revisions

Revision 3b6d1043 (diff)
Added by intrigeri over 3 years ago

Mark two tests as fragile.

refs: #11457

Revision d2276416 (diff)
Added by intrigeri over 3 years ago

Revert "Take into account that button ordering differs depending on the locale's text direction."

This reverts commit 6648c77d0df4ccfcf0f4a891e9ad41e426a676c4.

refs: #11457

Revision cdb9a84c (diff)
Added by intrigeri 4 months ago

Test suite: remove obsolete fragile tag (refs: #11457)

This scenario never failed on Jenkins in the last 2 months.

Revision a7ca22af
Added by Sandro Knauß 4 months ago

Merge remote-tracking branch 'test/update-fragile-tags' into devel (refs: #16281, #11890)

Closes: #13470, #11606, #11457, #11563, #11591
Closes: #10499, #11584, #11414, #11453, #11463

History

#1 Updated by intrigeri over 3 years ago

  • Feature Branch set to test/11457-I-close-the-browser-is-fragile

#2 Updated by spriver over 2 years ago

  • Subject changed from "I close the (?:Unsafe|I2P) Browser" step is fragile to "I close the Unsafe Browser" step is fragile

#3 Updated by spriver over 2 years ago

  • Assignee set to anonym
  • QA Check set to Ready for QA
  • Feature Branch changed from test/11457-I-close-the-browser-is-fragile to spriver:feature/11457-closing-unsafe-browser-is-fragile

Done this by implementing clicking on the Unsafe Browser's icon on the start page.

#4 Updated by intrigeri over 2 years ago

  • Target version set to Tails_3.2

#5 Updated by anonym over 2 years ago

  • Blocks Feature #13239: Core work 2017Q3: Test suite maintenance added

#6 Updated by anonym over 2 years ago

  • Assignee changed from anonym to spriver
  • % Done changed from 0 to 50
  • QA Check changed from Ready for QA to Dev Needed

From commit:023a16b0fbf2bff4a70285b9823d57dfea64be7c:

 When /^I close the Unsafe Browser$/ do
+  # Click on the picture on the start page to have the focus
+  # definitely in the Unsafe Browser before closing it
+  @screen.click('UnsafeBrowserHomepage.png')
   @screen.type("q", Sikuli::KeyModifier.CTRL)
 end

My only gripe here is that this step will only work if the Unsafe Browser's homepage is shown, and not if we have navigated to any other page. I suppose we currently only use this step in that situation, but it's good practice to avoid such surprising preconditions.

Normally how we deal with window detection and focusing is to have an image of the window title that we look for and click, respectively. It pains me to have us introduce more images, but I think that is the sensible solution here.

#7 Updated by BitingBird over 2 years ago

  • Status changed from Confirmed to In Progress

#8 Updated by intrigeri over 2 years ago

  • Target version changed from Tails_3.2 to Tails_3.3

#9 Updated by intrigeri about 2 years ago

  • Blocks Feature #13240: Core work 2017Q4: Test suite maintenance added

#10 Updated by intrigeri about 2 years ago

  • Blocks deleted (Feature #13239: Core work 2017Q3: Test suite maintenance)

#11 Updated by anonym about 2 years ago

  • Target version changed from Tails_3.3 to Tails_3.5

#12 Updated by intrigeri almost 2 years ago

  • Blocks deleted (Feature #13240: Core work 2017Q4: Test suite maintenance)

#13 Updated by anonym almost 2 years ago

  • Target version changed from Tails_3.5 to Tails_3.6

#14 Updated by bertagaz almost 2 years ago

  • Target version changed from Tails_3.6 to Tails_3.7

#15 Updated by bertagaz over 1 year ago

  • Target version changed from Tails_3.7 to Tails_3.8

#16 Updated by intrigeri over 1 year ago

  • Target version changed from Tails_3.8 to Tails_3.9

#17 Updated by intrigeri over 1 year ago

  • Target version changed from Tails_3.9 to Tails_3.10.1

#18 Updated by intrigeri about 1 year ago

  • Target version changed from Tails_3.10.1 to Tails_3.11

#19 Updated by CyrilBrulebois 12 months ago

  • Target version changed from Tails_3.11 to Tails_3.12

#20 Updated by intrigeri 11 months ago

  • Target version deleted (Tails_3.12)

#21 Updated by intrigeri 4 months ago

  • Affected tool set to Unsafe Browser

#22 Updated by intrigeri 4 months ago

  • Status changed from In Progress to Needs Validation
  • Assignee changed from spriver to hefee
  • Target version set to Tails_4.0
  • Feature Branch changed from spriver:feature/11457-closing-unsafe-browser-is-fragile to https://salsa.debian.org/tails-team/tails/merge_requests/33

#23 Updated by Anonymous 4 months ago

  • Status changed from Needs Validation to Resolved
  • % Done changed from 50 to 100

Also available in: Atom PDF