Bug #10288: Fix newly identified issues to make our test suite more robust and faster
robust_notification_wait sometimes opens the Applications menu which breaks tests
Test suite: close the notification bar by pressing ESC, instead of opening the Applications menu.
The Applications menu often covers other elements that we're looking for on
Test suite: unmark scenarios previously broken by the notifications handling as fragile.
#3 Updated by intrigeri about 3 years ago
One more case, attaching video. I'll mark this test as fragile, and IMO we should go on doing this until we can check if this breaks too many tests and needs to be prioritized higher.
#4 Updated by intrigeri about 3 years ago
- Priority changed from Normal to Elevated
FTR, all recent test failures I've seen while running tests on 4 branches intensively were caused either by this problem, or by #11398 => bumping priority.
And now I wonder: did we ever see this before we merged the dogtail branch? I can't remember this, and this ticket is pretty new, and I see this problem very often these days. So I wonder if
robust_notification_wait is really guilty, or if we're experiencing some dogtail-induced bug.
#5 Updated by intrigeri about 3 years ago
- Status changed from Confirmed to In Progress
- Feature Branch set to test/11401-notification-wait-is-fragile
def robust_notification_wait I see:
# Click anywhere to close the notification applet @screen.hide_cursor @screen.click("GnomeApplicationsMenu.png") @screen.hide_cursor
... which probably explains very clearly what we're seeing. JFTR this code was introduced in bd2d2bdf. I'm pushing a different implementation, will merge it into test/10497-tor-bootstrap-is-fragile so that we can see how it goes in Jenkins.
#10 Updated by intrigeri about 3 years ago
- Subject changed from robust_notification_wait sometimes fails to close a notification which breaks tests to robust_notification_wait sometimes opens the Applications menu which breaks tests
- Description updated (diff)
(Repurposing this ticket to track the specific problem I'm trying to fix here, instead of two unrelated things at a time. The issue it was previously about, that's specifically about browser close notifications, is now tracked by #11457.)
#12 Updated by intrigeri about 3 years ago
- Assignee changed from intrigeri to anonym
- % Done changed from 10 to 50
- QA Check set to Ready for QA
I've not seen this bug happen anymore on Jenkins with this fix in, while it happened pretty regularly before. FTR this branch has been merged into the one for #10497, and in turn into the ones for #10442, #10376 and #10381, so it has seen a fair amount of testing. Then I think we're good and should merge this :)