Project

General

Profile

Bug #11190

The automated test suite harcodes the expected jvm to use

Added by anonym almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
Test suite
Target version:
Start date:
03/04/2016
Due date:
% Done:

100%

QA Check:
Pass
Feature Branch:
test/11190-guess-JAVA_HOME
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

We explicitly export JAVA_HOME="/usr/lib/jvm/java-7-openjdk-amd64" (in run_test_suite) effectively hardcoding that Java 7 should be used. This breaks the automated test suite in current Debian Sid, which has Java 8.

There are two fixes, either to use /usr/lib/jvm/default-java, or to not set it at all, and rely on the Debian specific 0005-Fill-JAVA_HOME-with-a-sensible-value-if-not-set-when.patch which I think I am partial to. Both fixes the issue on Sid for me.

Associated revisions

Revision 89d15bd9 (diff)
Added by anonym almost 3 years ago

Let ruby-rjb guess JAVA_HOME instead fixing on one jvm version.

The appropriate jvm to use differs between Debian versions, so setting
a specific one is not convenient when supporting multiple Debian
versions. For instance, the current hardcoded value, which fixes on
the Java 7 jvm, breaks rjb in Debian Sid, so the automated test suite
cannot be run at all.

Let's instead not set it explicitly, and rely on the Debian-specific
(via 0005-Fill-JAVA_HOME-with-a-sensible-value-if-not-set-when.patch)
jvm guessing mechanism.

Will-fix: #11190

Revision e06d57e8
Added by anonym almost 3 years ago

Merge remote-tracking branch 'origin/test/11190-guess-JAVA_HOME' into testing

Fix-committed: #11190

History

#1 Updated by anonym almost 3 years ago

  • Priority changed from Normal to High

Raising priority, cause this is very inconvenient for me this close to a release.

#2 Updated by anonym almost 3 years ago

  • Status changed from Confirmed to In Progress
  • Assignee deleted (anonym)
  • % Done changed from 0 to 50
  • Feature Branch set to test/11190-guess-JAVA_HOME

A review would be welcome, in particular if someone could try this on Debian Jessie. But if this doesn't break the test suite on Jenkins' isotesters I'll probably merge it myself any way.

#3 Updated by anonym almost 3 years ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

#4 Updated by anonym almost 3 years ago

Edit: removed the previous comment, which was meant for #11176.

Any way, I've seen this branch pass on Jenkins, and so merged this to make my Sid system happy.

#5 Updated by anonym almost 3 years ago

  • QA Check set to Pass

#6 Updated by anonym almost 3 years ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF