Project

General

Profile

Bug #11135

Feature #11151: Speed up the build of the website

Disable translations of /news/reports

Added by sajolida over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
02/17/2016
Due date:
% Done:

100%

Feature Branch:
web/11135-disable-reports-translation
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

As we add more pages and more languages, the website is become super slow to build. A simple way of speeding this up is to enable translations on less page. Reports /news/report* could be interesting for a multilingual audience, but in reality they are not translated and so they're slowing the build for nothing. As of today the have been translated as follow:

- .fr.po: 0%
- .de.po: 0%
- .pt.po: 0%
- .fa.po: 89%

I propose to disable translations on them.

testpagespec.mdwn (1.9 KB) sajolida, 02/21/2016 06:08 PM

testpagespec.mdwn (5.04 KB) sajolida, 02/24/2016 04:02 PM


Related issues

Related to Tails - Bug #9671: rss and atom feed of l10n news show po file source Resolved 07/03/2015
Blocked by Tails - Bug #11227: Website: Broken links at https://tails.boum.org/security/ Resolved 03/13/2016

Associated revisions

Revision e6bf5c8d
Added by intrigeri over 3 years ago

Merge remote-tracking branch 'origin/web/11135-disable-reports-translation'

refs: #11135

Revision ffb00ca7 (diff)
Added by sajolida about 3 years ago

Add a comment to update po_translatable_pages when release 3.0, 4.0, etc. (Will-fix: #11135)

Revision 43af30fa
Added by intrigeri about 3 years ago

Merge remote-tracking branch 'origin/web/11135-disable-reports-translation'

Closes: #11135

Revision 2dee271a
Added by intrigeri about 3 years ago

Merge remote-tracking branch 'origin/web/11135-disable-reports-translation'

Closes: #11135

History

#1 Updated by intrigeri over 3 years ago

I propose to disable translations on them.

Agreed.

(Now, I didn't check myself, but I doubt that reports are part of the most efficient targets regarding decreasing the website build time in a measurable manner. Whatever, every bit is good to have :)

#2 Updated by spriver over 3 years ago

I also thought of deactivating the build old news pages. Do we actually need translations for versions below 1.0?

#3 Updated by intrigeri over 3 years ago

I also thought of deactivating the build old news pages. Do we actually need translations for versions below 1.0?

Not in the ISO, at least.

#4 Updated by sajolida over 3 years ago

Shall we create a ticket to investigate more options to speed up the wiki build time? But then it might never get closed...

#5 Updated by intrigeri over 3 years ago

Shall we create a ticket to investigate more options to speed up the wiki build time?

Yes, please :)

But then it might never get closed...

I suggest we set a measurable goal (like getting back to what we had before adding the IA + N%) on that ticket, so it's not a never-ending task.

#6 Updated by sajolida over 3 years ago

  • Related to Bug #9671: rss and atom feed of l10n news show po file source added

#7 Updated by sajolida over 3 years ago

  • Assignee set to sajolida
  • Parent task set to #11151
  • Type of work changed from Discuss to Code

I guess I'll be the ikiwiki geek on this one.

#8 Updated by sajolida over 3 years ago

  • File testpagespec.mdwn added
  • Assignee changed from sajolida to intrigeri
  • QA Check set to Ready for QA
  • Feature Branch set to web/11135-disable-reports-translation

Done in web/11135-disable-reports-translation. Please have a look. I'm attaching a testpagespec test suite :)

#9 Updated by intrigeri over 3 years ago

  • Target version set to Tails_2.2

#10 Updated by intrigeri over 3 years ago

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 50

#11 Updated by intrigeri over 3 years ago

  • Assignee changed from intrigeri to sajolida
  • % Done changed from 50 to 70
  • QA Check changed from Ready for QA to Info Needed

Pushing (and I'll deal with ).

One side effect is that the reports don't appear at all anymore e.g. on the non-English homepage, /news/, and presumably on the corresponding Atom & RSS feeds. Was this intended?

#12 Updated by intrigeri over 3 years ago

  • Priority changed from Normal to Elevated

(Raising priority a bit since this introduces something that looks like a regression to me.)

#13 Updated by sajolida over 3 years ago

Oops! We needed to tweak the inline directive in there... :(

#14 Updated by sajolida over 3 years ago

  • File testpagespec.mdwn added
  • Assignee changed from sajolida to intrigeri
  • QA Check changed from Info Needed to Ready for QA

Tentatively fixed in 4ca7ed3, please have a look.

I'm putting a testpagespec in attachment but you have to put it somewhere translatable (under /doc for example) and check both the English and German versions.

#15 Updated by intrigeri over 3 years ago

  • Assignee changed from intrigeri to sajolida
  • Target version changed from Tails_2.2 to Tails_2.3
  • % Done changed from 70 to 90
  • QA Check changed from Ready for QA to Dev Needed

Thanks! I've merged this as-is in order to not let the regression live on our website for too long.

I'd like to see safeguards added so that the duplicated info doesn't get outdated (e.g. comments in the ikiwiki config file + the place where the inline directive duplicates it), otherwise I'm pretty sure that we'll see more "page X appears on English news but not on the German one" bugs later on. What do you think?

#16 Updated by sajolida about 3 years ago

  • Assignee changed from sajolida to intrigeri
  • QA Check changed from Dev Needed to Ready for QA

I pushed commit ffb00ca with a bunch of comments.

But I don't think that not updating the list could have lead to "page X appears on English news but not on the German one" so maybe I misunderstood your intention...

#17 Updated by sajolida about 3 years ago

I pushed some more to take into account #11227. So I merge web/11227-broken-links-on-security into this one and #11227 should be solved first. Sorry for the spaghetti!

#18 Updated by sajolida about 3 years ago

  • Related to Bug #11227: Website: Broken links at https://tails.boum.org/security/ added

#19 Updated by intrigeri about 3 years ago

  • Related to deleted (Bug #11227: Website: Broken links at https://tails.boum.org/security/)

#20 Updated by intrigeri about 3 years ago

  • Blocked by Bug #11227: Website: Broken links at https://tails.boum.org/security/ added

#21 Updated by intrigeri about 3 years ago

I pushed commit ffb00ca with a bunch of comments.

Thanks! The comments look perfect to me, I will test and (I guess) merge.

But I don't think that not updating the list could have lead to "page X appears on English news but not on the German one"

Well, in my book that's precisely the kind of problems this ticket has been about since a month. It happened already that this duplicated info getting desynchronized triggered that effect (#11135#note-11). And then you resync'ed stuff with 4ca7ed3, and it fixed the bug. Did you lose track of the context of this discussion, or am I myself confused?

#22 Updated by intrigeri about 3 years ago

I pushed some more to take into account #11227. So I merge web/11227-broken-links-on-security into this one and #11227 should be solved first.

OK, I've expressed this with a Redmine "blocked by" relationship.

#23 Updated by intrigeri about 3 years ago

  • Status changed from In Progress to Resolved
  • Assignee deleted (intrigeri)
  • % Done changed from 90 to 100
  • QA Check changed from Ready for QA to Pass

Merged, thanks!

#24 Updated by sajolida about 3 years ago

  • Status changed from Resolved to In Progress
  • Assignee set to sajolida
  • QA Check changed from Pass to Dev Needed

As drebs noticed on tails-l10n, I should also update the inline directives for the news section on the homepage.

#25 Updated by sajolida about 3 years ago

  • Assignee changed from sajolida to intrigeri
  • Priority changed from Elevated to Normal
  • QA Check changed from Dev Needed to Ready for QA

Fixed again in 09ad601..a051691. Assigning to intrigeri who's been following up on this until now.

#26 Updated by intrigeri about 3 years ago

  • Target version changed from Tails_2.3 to Tails_2.4

#27 Updated by intrigeri about 3 years ago

  • Assignee changed from intrigeri to sajolida
  • QA Check changed from Ready for QA to Dev Needed

Looks good, except in various places I see "Also update ikiwiki.setup, index.mdwn" or similar: I think you mean "index.html" instead. I'll build and merge once this has been polished :)

(Meta: I hope this indeed measurably improves build time, because in the end we'll have spent quite some time on this ticket.)

#28 Updated by sajolida about 3 years ago

  • Assignee changed from sajolida to intrigeri
  • QA Check changed from Dev Needed to Ready for QA

Should be fixed in 128508a.

#29 Updated by intrigeri about 3 years ago

  • Assignee changed from intrigeri to sajolida
  • % Done changed from 100 to 90
  • QA Check changed from Ready for QA to Dev Needed

Can you please merge current master into the topic branch and resolve conflicts? Then I'm happy to test and merge.

#30 Updated by sajolida about 3 years ago

  • Assignee changed from sajolida to intrigeri
  • QA Check changed from Dev Needed to Ready for QA

Done in 80b8771.

#31 Updated by intrigeri about 3 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

#32 Updated by intrigeri about 3 years ago

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

Also available in: Atom PDF