- what happens with translations which are not committed etc.
#2 Updated by muri almost 4 years ago
- Assignee changed from muri to u
- % Done changed from 0 to 10
i thought this would be more complex, but:
one person0 changes file.de.po. as soon as person clicks the 'save' button (or as soon as inside weblate enough votes for a suggested translation of file.de.po are collected) the file.de.po gets saved to the repository.
if person1 changes file2.fr.po and saves that, that file gets saved to the same repository.
then someone (or a cron job) has to commit. then apparently we have one commit for every file, so in the example we have:
git log commit b35b6fb9dea9558736a60a13b4cb30f9ccfaf881 Author: Weblate Admin <firstname.lastname@example.org> Date: Mon Feb 15 19:35:43 2016 +0000 Translated using Weblate (French) Currently translated at 20.0% (4 of 20 strings) Author: Weblate Admin <email@example.com> Date: Mon Feb 15 19:15:45 2016 +0000 Translated using Weblate (German) Currently translated at 3.6% (2 of 55 strings)
(the commit message can be changed to contain the components/files name)
one problem i found: if a string is present in multiple files, weblate tries to translate this string in all the files. so if person0 translates the string
that string gets translated in all the files
#5 Updated by muri over 3 years ago
On 02/17/2016 01:27 PM, sajolida wrote:
muri: How would this related to the idea of "Weblate should only commit reviewed changes." proposed in #10257#note-21?
well, there is the possibility of doing a 'review process' in weblate.
thats what i was referring to when writing "as soon as inside weblate
enough votes for a suggested translation of file.de.po are collected".
suggesting a translation i'm automatically voting for that
translation. now another person (i.e. spriver) reviews that translation.
there are sentences where we agree, so he also votes for that. if we say
2 votes are enough (i.e. the string has been reviewed), these strings
get saved to disk.
so the exact wording would be: weblate only saves strings to files that
have been reviewed (if we use the voting mechanism). everything that has
been saved to files gets commited.
(u: please correct me if i'm wrong. maybe there is a setting i oversaw,
that changes all these states...)
#6 Updated by sajolida over 3 years ago
- QA Check set to Info Needed
Uff, this discussion is complicated to split between #10802, #10257, and #10331. So for this ticket in particular I understand that your finding is that Weblate has two states for translations: translations pending for review are stored in the database only, and only translations that have been reviewed can be written to the disk. That's great!
Regarding the review process itself, I still don't like the idea of the votes and think we need a review role (otherwise someone can create N accounts on Weblate and vote for her own stuff).
u: Actually, I'm not sure what was the objective of this ticket... Are we done or what else do we need to investigate?
#7 Updated by sajolida over 3 years ago
- Status changed from Confirmed to Resolved
- Assignee deleted (
- QA Check deleted (
Clarification after checking with Emma and Muri. Weblate only knows about two states for translations:
- "Suggestions" are stored in the database only.
- "Translations" are written to the PO files in the Weblate repo.
- Then translations get committed to the Weblate repo whenever Weblate needs it.
Closing this ticket now.