Feature #7563: Update the automated test suite for Jessie ISO images
Regression in "I synchronize keys in Seahorse" recovery_proc
@@ -120,7 +117,7 @@ Then /^I synchronize keys in Seahorse$/ do if @screen.exists('GnomeCloseButton.png') || !$vm.has_process?('seahorse') step 'I kill the process "seahorse"' if $vm.has_process?('seahorse') debug_log('Restarting Seahorse.') - start_or_restart_seahorse(withapplet = @withgpgapplet) + start_or_restart_seahorse(withgpgapplet) end end
withgpgapplet is not defined in this scope. I think this was exactly why kytv used something with broader scope than a local variable in the first place.
In practice, I think it means that if the initial sync fails, and we meant to test with Seahorse started from the OpenPGP applet, then the retries will be run from a Seahorse started differently, which is not what we want to test in this case.
Make sure we restart Seahorse in the same manner as initially.
We need to save the manner we started Seahorse in in a greater scope
(hence the class variable).
Seahorse test suite: update expected OpenPGP Applet icon to work even when it's truncated.
While running tests for test/10782-restart-seahorse-in-same-manner,
I've seen the "I start Seahorse via the Tails OpenPGP Applet" step
fail every time due to "FindFailed: can not find GpgAppletIconNormal.png
on the screen", apparently because the OpenPGP Applet icon was a tiny
bit truncated. With this small change to the image, it passes just fine.
#5 Updated by anonym almost 3 years ago
- Assignee changed from kytv to intrigeri
kytv: in case you can't handle this review within a week from now, please let me know, so I take it over. Note that I won't be able to do it after Jan 21, so I need to know pretty quickly.
Since we haven't heard anything from kytv yet I'm assigning it to you, as decided earlier.