Project

General

Profile

Bug #10376

Bug #10288: Fix newly identified issues to make our test suite more robust and faster

The "the Tor Browser loads the (startup page|Tails roadmap)" step is fragile

Added by kytv over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Test suite
Target version:
Start date:
10/15/2015
Due date:
% Done:

100%

Feature Branch:
test/10376-fix_startup-page_roadmap-test-is-fragile
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

Refactoring would allow retry_tor magic to be used for this step in case loading the page fails.


Related issues

Blocked by Tails - Feature #9521: Use the chutney Tor network simulator in our test suite Resolved 04/15/2016
Blocked by Tails - Bug #10497: wait_until_tor_is_working helper is fragile Resolved 11/06/2015

Associated revisions

Revision 06634d46
Added by anonym about 3 years ago

Merge remote-tracking branches 'origin/test/10376-fix_startup-page_roadmap-test-is-fragile' and 'origin/test/11401-notification-wait-is-fragile' into testing

Fix-committed: #10376, #10497, #11398, #11401, #11464

History

#1 Updated by kytv over 3 years ago

  • Parent task set to #10288

#2 Updated by kytv over 3 years ago

anonym wrote:

The 'I see the Tails roadmap URL' doesn't use the retrying-magic we have in the 'I open the address ...' step. We should refactor out that code from the latter so it can be used in the former step.

#3 Updated by anonym over 3 years ago

  • Subject changed from Refactor the "loaded the Tails roadmap" step in the test suite to The "the Tor Browser loads the (startup page|Tails roadmap)" step is fragile

kytv wrote:

anonym wrote:

The 'I see the Tails roadmap URL' doesn't use the retrying-magic we have in the 'I open the address ...' step. We should refactor out that code from the latter so it can be used in the former step.

Sorry, I meant that the 'the Tor Browser has started and loaded the Tails roadmap' step is fragile. Hence we need to refactor out the retrying code from the 'I open the address ...' step so it can be used in this step as well.

Note that the problematic step's definition matches /^the Tor Browser (?:has started and )?load(?:ed|s) the (startup page|Tails roadmap)$/ so all scenarios using it for the startup page case are also fragile. That's another 11 scenarios (essentially all of torified_browsing.feature).

#4 Updated by intrigeri over 3 years ago

  • Assignee set to anonym

kytv, anonym: this has a target version (rightfully I guess), so it needs an assignee. Tentatively assigning to anonym, please sort this out together :)

#6 Updated by intrigeri over 3 years ago

  • Tracker changed from Feature to Bug

#7 Updated by anonym over 3 years ago

  • Assignee changed from anonym to kytv
  • Target version changed from Tails_1.7 to Tails_1.8

Could this reasonably be part of the rest of the test suite work you have? Optimistically reassigning to you (note that I'll do this for the other children of #10288, but won't comment there).

In any case, let's postpone this to 1.8. We have way to much on our plates this cycle.

#8 Updated by kytv over 3 years ago

  • Feature Branch set to test/1e5fd8f-fix_startup-page_roadmap-test-is-fragile

#9 Updated by kytv over 3 years ago

  • Feature Branch changed from test/1e5fd8f-fix_startup-page_roadmap-test-is-fragile to test/10376-fix_startup-page_roadmap-test-is-fragile

#10 Updated by anonym over 3 years ago

Branch imported to our Git (but you forgot "kytv/" in that field, so no update), scenarios marked as @fragile in devel.

#12 Updated by anonym over 3 years ago

  • Assignee changed from kytv to anonym

There might be something smart to do that will fix all of {#10442, #10381, #10376} at the same time, and increase browser page loading throughout the test suite.

#13 Updated by intrigeri over 3 years ago

  • Target version changed from Tails_1.8 to Tails_2.0

(We're going to mark as fragile all tests that depend on Tor to have bootstrapped for the moment => not so urgent.)

#14 Updated by anonym over 3 years ago

  • Target version changed from Tails_2.0 to Tails_2.2

#15 Updated by anonym over 3 years ago

  • Priority changed from Normal to Elevated
  • Target version changed from Tails_2.2 to Tails_2.4

#16 Updated by anonym over 3 years ago

  • Priority changed from Elevated to Normal
  • Target version deleted (Tails_2.4)

I'm gonna gamble and focus on Chutney (#9521) hoping it will fix this issue.

#17 Updated by anonym over 3 years ago

  • Blocked by Feature #9521: Use the chutney Tor network simulator in our test suite added

#19 Updated by intrigeri about 3 years ago

  • Assignee changed from anonym to intrigeri
  • Target version set to Tails_2.4

#20 Updated by intrigeri about 3 years ago

  • Blocked by Bug #10497: wait_until_tor_is_working helper is fragile added

#21 Updated by intrigeri about 3 years ago

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10

I'll wait a few days to see how it works in Jenkins, now that we are using chutney.

#22 Updated by intrigeri about 3 years ago

  • % Done changed from 10 to 60

This now works well (after flagging more tests as fragile), so we're only blocked by #10497 before this branch can be reviewed'n'merged.

#23 Updated by intrigeri about 3 years ago

  • Assignee changed from intrigeri to anonym
  • QA Check set to Ready for QA

#24 Updated by anonym about 3 years ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 60 to 100
  • QA Check changed from Ready for QA to Pass

#25 Updated by anonym about 3 years ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF