Project

General

Profile

Feature #10309

Feature #9203: Write content for all scenarios

Assistant: Write "Linux USB" scenario

Added by sajolida over 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Elevated
Assignee:
-
Category:
Installation
Target version:
Start date:
09/30/2015
Due date:
% Done:

100%

Feature Branch:
web/10309-linux-usb
Type of work:
End-user documentation
Blueprint:
Starter:
Affected tool:
Installation Assistant

Associated revisions

Revision e27590c5
Added by sajolida about 4 years ago

Merge branch 'web/10309-linux-usb' into web/assistant (Closes: #10309)

Conflicts:
wiki/src/install/win/usb.mdwn

History

#1 Updated by sajolida over 4 years ago

  • Parent task set to #9203

#2 Updated by sajolida over 4 years ago

  • Assignee changed from sajolida to tchou
  • Priority changed from Normal to Elevated
  • Feature Branch set to web/10309-linux-usb

So here is a first scenario that integrates the various inlining and CSS techniques that allow factorizing instructions as much as possible. It would be great if you could review this before Wednesday so I can merge it and base my work on the next scenarios on this one.

I'm not including the compiled HTML this time as it makes little sense. What's interesting to review here is the factorizing techniques themselves and also, to a lesser extend, the Git process to make this easier to analyze.

So you should either review:

git log -p origin/web/assistant...origin/web/10309-linux-usb
git diff origin/web/assistant...origin/web/10309-linux-usb

#3 Updated by sajolida over 4 years ago

  • QA Check set to Ready for QA

#4 Updated by tchou over 4 years ago

  • Assignee changed from tchou to sajolida

So the <STYLE> tag will be in the <BODY> ?

I had a look to http://www.w3.org/TR/html401/present/styles.html#edef-STYLE and tested some html in the validator and it said me "The element named above was found in a context where it is not allowed. This could mean that you have incorrectly nested elements -- such as a "style" element in the "body" section instead of inside "head" -- or two elements that overlap (which is not allowed)."

Anyway, I think that it will work on all web brownsers.

#5 Updated by sajolida over 4 years ago

  • Assignee changed from sajolida to tchou

Thanks for pointing that out! I didn't know about it.

So I moved this little bit of CSS to a dedicated stylesheet with commit ada0e11. Please check.

Also, you didn't mention anything else in your review, does that mean that this was the only issue you found and I can merge now? If so, then I can be proud of me :)

#6 Updated by sajolida about 4 years ago

Ping on this simple issue 7 days later... That's blocking me from merging quite some more branches.

#7 Updated by tchou about 4 years ago

  • Assignee changed from tchou to sajolida
  • QA Check deleted (Ready for QA)

Sorry, of course it's ok.

#8 Updated by sajolida about 4 years ago

  • Status changed from Confirmed to Resolved
  • % Done changed from 0 to 100

#9 Updated by sajolida about 4 years ago

  • Assignee deleted (sajolida)

Cool, thanks!

Also available in: Atom PDF