Project

General

Profile

Bug #10219

Feature #8539: Make the test suite robust enough to be run as part of a CI setup

Escape regexp used to match nick in CTCP replies

Added by anonym almost 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Test suite
Target version:
Start date:
09/17/2015
Due date:
% Done:

100%

Feature Branch:
test/10219-escape-nick-for-ctcp-responses
Type of work:
Code
Blueprint:
Starter:
Affected tool:

Description

Look at this from the CTCP helper:

    if m.ctcp? and /^:#{@spam_target}!/.match(m)

Our Pidgin nick's have a 10% chance to include a ^, which will break that regexp. We need to escape all characters in the nickname.

Associated revisions

Revision 87822647 (diff)
Added by anonym over 3 years ago

Escape regexp used to match nick in CTCP replies.

Our Pidgin nick's have a 10% chance to include a ^, which will break
that regexp. We need to escape all characters in the nick.

Will-fix: #10219

Revision 4fd56700
Added by intrigeri over 3 years ago

Merge remote-tracking branch 'origin/test/10219-escape-nick-for-ctcp-responses' into stable

Fix-committed: #10219

History

#1 Updated by anonym almost 4 years ago

  • Parent task set to #8539

#2 Updated by anonym almost 4 years ago

  • Status changed from Confirmed to In Progress

#3 Updated by anonym almost 4 years ago

  • Assignee changed from anonym to kytv
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to test/10219-escape-nick-for-ctcp-responses

#4 Updated by kytv over 3 years ago

Code looks good (and necessary) but still doing the obligatory testing.

#5 Updated by kytv over 3 years ago

  • Assignee changed from kytv to intrigeri

Testing passed, although I'm not sure how it could have failed. :)

#6 Updated by intrigeri over 3 years ago

  • Target version changed from Tails_1.6 to Tails_1.7

#10 Updated by intrigeri over 3 years ago

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

#11 Updated by intrigeri over 3 years ago

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#12 Updated by anonym over 3 years ago

  • Status changed from Fix committed to Resolved

Also available in: Atom PDF