Liveusb-creator should be migrated to python3.
#10 Updated by firstname.lastname@example.org 6 months ago
- Feature Branch set to https://gitlab.com/saschamarkus/liveusb-creator/tree/feature/10085-Port-Tails-Installer-To-Python3
Removed implementation for Windows
Removed implementation to download images from Fedora
-> we don't depend on python-urlgrabber anymore
Removed implementation to read config files (there were non in tails 3.13.1)
-> we don't depend on python-configobj anymore
-> we can remove the placeholder /etc/tails-installer/deprecated-outside-of-Tails
Replaced usage of python2's statvfs.F_BSIZE and statvfs.F_BAVAIL
#11 Updated by email@example.com 6 months ago
- Assignee changed from firstname.lastname@example.org to kurono
- QA Check set to Ready for QA
Hi @kurono I think I'm done with porting the installer to python3.
I wrote a couple of times Tails to an USB stick using downloaded ISOs (the current release and a nightly) and cloning the running Tails.
Seems to work fine.
The Fedore and Windows stuff is gone.
I checked the code with flake8. There are still long lines but I think it would be better to add a configuration for flake8 to the setup.py to allow 100 or 120 chars.
There was a mix of ' and " as string delimiters. I changed all of them to ' because I'm used to do it that way at work too. I hope that's OK.
- Assignee deleted (
- Target version set to Tails_3.16
I understand that Sascha did some work on this 3 months ago (thanks a bunch!) but never got a review from kurono. I think that we should stop waiting for kurono and find other reviewer in time for the next release, no?
- Target version changed from Tails_3.16 to Tails_3.17
I understand that Sascha did some work on this 3 months ago (thanks a bunch!) but never got a review from kurono.
I understand the same.
I think that we should stop waiting for kurono and find other reviewer in time for the next release, no?
Agreed, modulo this is too invasive to land in a bugfix release, so re-targeting to 3.17. Still, the earlier a first review is done, the better :)
This is a huge change, there are 643 additions and 1516 deletions. It's impractical to do the review here, without inline comments, so I won't taker a deeper look at the changes without a gitlab MR.